From: Greg KH <greg@kroah.com>
To: Patryk Mezydlo <mezydlo.p@gmail.com>
Cc: mwelling@ieee.org, linux-kernel@vger.kernel.org, lidza.louina@gmail.com
Subject: Re: [PATCH] Staging: dgnc: fix coding style in dgnc_tty.c
Date: Tue, 3 May 2016 14:08:21 -0700 [thread overview]
Message-ID: <20160503210821.GA26753@kroah.com> (raw)
In-Reply-To: <20160503183727.GA2379@debian>
On Tue, May 03, 2016 at 08:37:27PM +0200, Patryk Mezydlo wrote:
> Fix checkpatch.pl warning about 'line over 80 characters'.
> I just split line with function.
>
> Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_tty.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index 9aa0ba0..b818b0a 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -186,7 +186,8 @@ int dgnc_tty_register(struct dgnc_board *brd)
> if (IS_ERR(brd->serial_driver))
> return PTR_ERR(brd->serial_driver);
>
> - snprintf(brd->serial_name, MAXTTYNAMELEN, "tty_dgnc_%d_", brd->boardnum);
> + snprintf(brd->serial_name, MAXTTYNAMELEN,
> + "tty_dgnc_%d_", brd->boardnum);
Why move the string to a new line? It didn't need to be there, did it?
prev parent reply other threads:[~2016-05-03 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 18:37 [PATCH] Staging: dgnc: fix coding style in dgnc_tty.c Patryk Mezydlo
2016-05-03 21:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503210821.GA26753@kroah.com \
--to=greg@kroah.com \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mezydlo.p@gmail.com \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.