From: Johan Hovold <johan@kernel.org>
To: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code.
Date: Wed, 4 May 2016 09:28:34 +0200 [thread overview]
Message-ID: <20160504072834.GA1367@localhost> (raw)
In-Reply-To: <1462323143-27514-1-git-send-email-konstantin.shkolnyy@gmail.com>
On Tue, May 03, 2016 at 07:52:23PM -0500, Konstantin Shkolnyy wrote:
> Replaced magic numbers used in the CRTSCTS flag code with symbolic names
> from the chip specification.
>
> Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
This patch does not even compile. Please be more careful when
resubmitting. There are at least two compilation errors below.
> ---
> v4:
> Same series of patches, fixed names and defines by feedback.
> v3:
> Regenerated the patches correctly against the latest usb-next branch.
> v2
> Improved CRTSCTS fix by feedback. Dropped get_termios error handling fix.
In the future, if you have an aggregate changelog for a series, put it
in a cover letter. A cover letter is good to have anyway and should
provide a high-level summary of what the series does.
Thanks,
Johan
next prev parent reply other threads:[~2016-05-04 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 0:52 [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code Konstantin Shkolnyy
2016-05-04 7:28 ` Johan Hovold [this message]
2016-05-04 12:46 ` [EXT] " Konstantin Shkolnyy
2016-05-04 12:55 ` Johan Hovold
2016-05-04 13:17 ` Konstantin Shkolnyy
2016-05-04 13:22 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504072834.GA1367@localhost \
--to=johan@kernel.org \
--cc=konstantin.shkolnyy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.