From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id e78si126340wmc.3.2016.05.04.03.09.01 for ; Wed, 04 May 2016 03:09:01 -0700 (PDT) Date: Wed, 4 May 2016 12:08:50 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , Michael Buesch , Mylene JOSSERAND , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH] rtc: rv3029: hide unused i2c device table Message-ID: <20160504100850.GA2430@piout.net> References: <1462355432-473635-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1462355432-473635-1-git-send-email-arnd@arndb.de> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 04/05/2016 at 11:50:02 +0200, Arnd Bergmann wrote : > The added support for SPI mode made it possible to configure the driver > when I2C is disabled, leaving an unused device table: > > drivers/rtc/rtc-rv3029c2.c:794:29: error: 'rv3029_id' defined but not used [-Werror=unused-variable] > > This moves the table inside of the #ifdef section that has the > only user, to avoid the harmless warning. > > Signed-off-by: Arnd Bergmann > Fixes: d08f50dd0afc ("rtc: rv3029: Add support of RV3049") > --- > drivers/rtc/rtc-rv3029c2.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757568AbcEDKJF (ORCPT ); Wed, 4 May 2016 06:09:05 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51443 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751311AbcEDKJD (ORCPT ); Wed, 4 May 2016 06:09:03 -0400 Date: Wed, 4 May 2016 12:08:50 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , Michael Buesch , Mylene JOSSERAND , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: rv3029: hide unused i2c device table Message-ID: <20160504100850.GA2430@piout.net> References: <1462355432-473635-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462355432-473635-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2016 at 11:50:02 +0200, Arnd Bergmann wrote : > The added support for SPI mode made it possible to configure the driver > when I2C is disabled, leaving an unused device table: > > drivers/rtc/rtc-rv3029c2.c:794:29: error: 'rv3029_id' defined but not used [-Werror=unused-variable] > > This moves the table inside of the #ifdef section that has the > only user, to avoid the harmless warning. > > Signed-off-by: Arnd Bergmann > Fixes: d08f50dd0afc ("rtc: rv3029: Add support of RV3049") > --- > drivers/rtc/rtc-rv3029c2.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com