From: Oleg Nesterov <oleg@redhat.com>
To: Kangjie Lu <kangjielu@gmail.com>
Cc: akpm@linux-foundation.org, peterz@infradead.org,
amanieu@gmail.com, linux-kernel@vger.kernel.org,
taesoo@gatech.edu, insu@gatech.edu, Kangjie Lu <kjlu@gatech.edu>
Subject: Re: [PATCH] infoleak fix1 in signal
Date: Wed, 4 May 2016 12:38:52 +0200 [thread overview]
Message-ID: <20160504103851.GA6977@redhat.com> (raw)
In-Reply-To: <1462308150-6083-1-git-send-email-kjlu@gatech.edu>
On 05/03, Kangjie Lu wrote:
>
> The stack object “info” has a total size of 128 bytes; however,
> only 28 bytes are initialized. The remaining uninitialized bytes
> are sent to userland via send_signal.
Not really, please see copy_siginfo_to_user(), case(__SI_CHLD). All members
copied to user-space are initialized afaics.
> @@ -1594,6 +1594,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
> sig = SIGCHLD;
> }
>
> + memset(&info, 0, sizeof(info));
looks like a false alarm to me.
Oleg.
prev parent reply other threads:[~2016-05-04 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 20:42 [PATCH] infoleak fix1 in signal Kangjie Lu
2016-05-04 10:38 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504103851.GA6977@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amanieu@gmail.com \
--cc=insu@gatech.edu \
--cc=kangjielu@gmail.com \
--cc=kjlu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=taesoo@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.