From: Matt Fleming <matt@codeblueprint.co.uk>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Kweh Hock Leong <hock.leong.kweh@intel.com>,
Bryan O'Donoghue <pure.logic@nexus-software.ie>,
joeyli <jlee@suse.com>
Subject: Re: [PATCH] efi/capsule: Make efi_capsule_pending() lockless
Date: Wed, 4 May 2016 14:36:56 +0100 [thread overview]
Message-ID: <20160504133656.GJ2839@codeblueprint.co.uk> (raw)
In-Reply-To: <20160504122042.GB4074@pd.tnic>
On Wed, 04 May, at 02:20:42PM, Borislav Petkov wrote:
> On Wed, May 04, 2016 at 12:46:05PM +0100, Matt Fleming wrote:
> > But emergency_restart() is called after bust_spinlocks(0) which can
> > reset oops_in_progress, so can't even use that to solve the panic
> > case.
>
> Blergh.
>
> So I guess you need an explicit call efi_stop_capsules() somewhere in
> the reboot path and be done with it. No reboot notifiers, no bla bla.
> Just one big hammer which STFU the EFI.
But you can't block in the reboot path and you can't guarantee you'll
interrupt an in-progress EFI capsule update call that started before
you entered the reboot path.
next prev parent reply other threads:[~2016-05-04 13:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 22:13 [PATCH] efi/capsule: Make efi_capsule_pending() lockless Matt Fleming
2016-04-30 22:13 ` Matt Fleming
2016-05-03 9:02 ` Borislav Petkov
[not found] ` <20160503090229.GC27540-fF5Pk5pvG8Y@public.gmane.org>
2016-05-03 14:12 ` Matt Fleming
2016-05-03 14:12 ` Matt Fleming
[not found] ` <20160503141201.GW2839-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-05-04 9:30 ` Borislav Petkov
2016-05-04 9:30 ` Borislav Petkov
[not found] ` <20160504093031.GA4074-fF5Pk5pvG8Y@public.gmane.org>
2016-05-04 11:46 ` Matt Fleming
2016-05-04 11:46 ` Matt Fleming
[not found] ` <20160504114605.GH2839-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-05-04 12:20 ` Borislav Petkov
2016-05-04 12:20 ` Borislav Petkov
2016-05-04 13:36 ` Matt Fleming [this message]
2016-05-04 14:35 ` Matt Fleming
[not found] ` <20160504143531.GK2839-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-05-05 14:27 ` Kweh, Hock Leong
2016-05-05 14:27 ` Kweh, Hock Leong
2016-05-05 14:36 ` Matt Fleming
[not found] ` <20160505143643.GN2839-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-05-05 14:55 ` One Thousand Gnomes
2016-05-05 14:55 ` One Thousand Gnomes
[not found] ` <F54AEECA5E2B9541821D670476DAE19C4A914755-j2khPEwRog0FyVwBAnZdSLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-06 1:32 ` Bryan O'Donoghue
2016-05-06 1:32 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504133656.GJ2839@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=hock.leong.kweh@intel.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.