Re: [Qemu-devel] [PATCH 0/9] QOM'ify hw/intc files

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Wed, May 04, 2016 at 03:56:25PM +0100, Peter Maydell wrote:
> On 30 March 2016 at 11:09, xiaoqiang zhao <zxq_yx_007@163.com> wrote:
> > This patch set QOM'ify files under hw/intc directory. See each commit
> > message for details.
> >
> > xiaoqiang zhao (9):
> >   hw/intc: QOM'ify etraxfs_pic.c
> >   hw/intc: QOM'ify exynos4210_combiner.c
> >   hw/intc: QOM'ify exynos4210_gic.c
> >   hw/intc: QOM'ify imx_avic.c
> >   hw/intc: QOM'ify lm32_pic.c
> >   hw/intc: QOM'ify pl190.c
> >   hw/intc: QOM'ify slavio_intctl.c
> >   hw/intc: QOM'ify grlib_irqmp.c
> >   hw/intc: QOM'ify omap_intc.c
> >
> >  hw/intc/etraxfs_pic.c         | 13 +++++----
> >  hw/intc/exynos4210_combiner.c | 14 +++++-----
> >  hw/intc/exynos4210_gic.c      | 39 ++++++++++++++-------------
> >  hw/intc/grlib_irqmp.c         | 27 +++++++++++--------
> >  hw/intc/imx_avic.c            | 15 +++++------
> >  hw/intc/lm32_pic.c            | 12 ++++-----
> >  hw/intc/omap_intc.c           | 63 +++++++++++++++++++++++++------------------
> >  hw/intc/pl190.c               | 13 +++++----
> >  hw/intc/slavio_intctl.c       | 14 +++++-----
> >  9 files changed, 109 insertions(+), 101 deletions(-)
> 
> Hi. I had a comment on patch 9 (omap_intc), but 1-8 look good.
> Only patches 2, 3, 4 and 6 are ARM-related.
> 
> SPARC, lm32, CRIS maintainers: do you want to take your patches
> or shall I just take 1-8 through the target-arm.next tree?

Feel free to take the CRIS stuff.

Thanks,
Edgar


> 
> Xaioqiang: if you're planning to do more of these QOMify
> series in future it might be easier on maintainers if you
> split them up by target architecture rather than by
> type-of-device. Otherwise we have lots of these series which
> touch devices for four different architectures and should
> really go through four different maintainers.
> 
> I forget if I've said this before, but I do really appreciate
> these patches -- cleanup of older devices to bring them up
> to modern QEMU standards is a thankless task but it's an
> important one.
> 
> thanks
> -- PMM