From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>, cardoe@cardoe.com
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.7] flask/policy: don't audit version queries
Date: Wed, 4 May 2016 15:25:47 -0400 [thread overview]
Message-ID: <20160504192547.GA7494@char.us.oracle.com> (raw)
In-Reply-To: <1462382446-6680-1-git-send-email-dgdegra@tycho.nsa.gov>
On Wed, May 04, 2016 at 01:20:46PM -0400, Daniel De Graaf wrote:
> Reported-by: Doug Goldstein <cardoe@cardoe.com>
> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Wait, why don't we give Doug a chance to respond about the
policy he is using. I am really not sure how we would deny
permission to these using the default policy.
Doug, can you confirm what/when you built the policy?
> ---
> tools/flask/policy/policy/modules/xen/xen.te | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tools/flask/policy/policy/modules/xen/xen.te b/tools/flask/policy/policy/modules/xen/xen.te
> index bef33b0..fed09a9 100644
> --- a/tools/flask/policy/policy/modules/xen/xen.te
> +++ b/tools/flask/policy/policy/modules/xen/xen.te
> @@ -155,6 +155,16 @@ allow domain_type xen_t:version {
> xen_changeset xen_pagesize xen_guest_handle
> };
>
> +# Version queries don't need auditing when denied. They can be
> +# encountered in normal operation by xl or by reading sysfs files in
> +# Linux, so without this they will show up in the logs. Since these
> +# operations return valid responses (like "denied"), hiding the denials
> +# should not break anything.
> +dontaudit domain_type xen_t:version {
> + xen_extraversion xen_compile_info xen_capabilities xen_changeset
> + xen_pagesize xen_guest_handle xen_commandline xen_build_id
> +};
> +
> ###############################################################################
> #
> # Domain creation
> --
> 2.5.5
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-04 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 17:20 [PATCH for-4.7] flask/policy: don't audit version queries Daniel De Graaf
2016-05-04 19:25 ` Konrad Rzeszutek Wilk [this message]
2016-05-04 19:44 ` Doug Goldstein
2016-05-04 19:59 ` Konrad Rzeszutek Wilk
2016-05-05 16:49 ` [PATCH] flask/policy: don't audit commandline / build_id queries Doug Goldstein
2016-05-05 18:00 ` Konrad Rzeszutek Wilk
2016-05-05 19:37 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504192547.GA7494@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=cardoe@cardoe.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.