From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3 1/2] virtio: cleanup
	virtio_dev_queue_setup()
Date: Wed, 4 May 2016 20:19:31 -0700
Message-ID: <20160505031931.GV5641@yliu-dev.sh.intel.com>
References: <1461673932-128879-1-git-send-email-jianfeng.tan@intel.com>
 <1461890926-16727-1-git-send-email-jianfeng.tan@intel.com>
 <1461890926-16727-2-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, huawei.xie@intel.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 6892C5686
 for <dev@dpdk.org>; Thu,  5 May 2016 05:15:46 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1461890926-16727-2-git-send-email-jianfeng.tan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Apr 29, 2016 at 12:48:45AM +0000, Jianfeng Tan wrote:
> +	if (queue_type < VTNET_RQ || queue_type > VTNET_CQ) {
> +		PMD_INIT_LOG(ERR, "invalid queue type: %d", queue_type);
> +		return -EINVAL;
>  	}

I'm thinking this check is not necessary. We can make sure it's a valid
queue type.

	--yliu