From: Theodore Ts'o <tytso@mit.edu>
To: Jens Axboe <axboe@fb.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: remove unnecessary bio get/put
Date: Thu, 5 May 2016 22:11:04 -0400 [thread overview]
Message-ID: <20160506021104.GB31860@thunk.org> (raw)
In-Reply-To: <20160321161523.GA12438@kernel.dk>
On Mon, Mar 21, 2016 at 10:15:23AM -0600, Jens Axboe wrote:
>
> ext4_io_submit() use to check for EOPNOTSUPP after bio submission,
> which is why it had to get an extra reference to the bio before
> submitting it. But since we no longer touch the bio after submission,
> get rid of the redundant get/put of the bio. If we do get the extra
> reference, we enter the slower path of having to flag this bio as now
> having external references.
>
> Signed-off-by: Jens Axboe <axboe@fb.com>
Jens, thanks for pointing this out. I've applied this to the ext4.git
tree.
- Ted
prev parent reply other threads:[~2016-05-06 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 16:15 [PATCH] ext4: remove unnecessary bio get/put Jens Axboe
2016-05-06 2:11 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506021104.GB31860@thunk.org \
--to=tytso@mit.edu \
--cc=axboe@fb.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.