From: Antonio Quartulli <a@unstable.cc>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org, mareklindner@neomailbox.ch
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function
Date: Fri, 6 May 2016 10:34:34 +0800 [thread overview]
Message-ID: <20160506023434.GA16484@prodigo.lan> (raw)
In-Reply-To: <2675515.pbCZCtK98O@sven-edge>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On Thu, May 05, 2016 at 10:17:18PM +0200, Sven Eckelmann wrote:
> On Friday 06 May 2016 02:46:37 Antonio Quartulli wrote:
> > the compiler can optimize functions within the same C file and therefore
> > there is no need to make it explicit.
> >
> > Remove the useless inline attribute for __batadv_store_uint_attr()
> >
> > Signed-off-by: Antonio Quartulli <a@unstable.cc>
> > ---
> > net/batman-adv/sysfs.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> This is not about this particular patch but for the patch series.
>
> Please check the attached test results of the daily build tests.
Sven,
do you know how I can deal with:
./net/batman-adv/types.h:1338: warning: No description found for parameter 'gw'
?
There are also other objects similar to that in the bat_algo_ops (i.e. iface,
neigh, ..), but the check complains about gw only ?
>
> Kind regards,
> Sve
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-06 2:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 18:46 [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: move GW mode and selection class to private data structure Antonio Quartulli
2016-05-06 1:06 ` Marek Lindner
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 3/7] batman-adv: make the GW selection class algorithm specific Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: split routing API data structure in subobjects Antonio Quartulli
2016-05-06 1:10 ` Marek Lindner
2016-05-06 1:20 ` Marek Lindner
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 5/7] batman-adv: statically print MAX TQ value in gateway table header Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: make GW election code protocol specific Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: B.A.T.M.A.N. V - implement GW selection logic Antonio Quartulli
2016-05-05 20:17 ` [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function Sven Eckelmann
2016-05-06 2:34 ` Antonio Quartulli [this message]
2016-05-06 7:23 ` Sven Eckelmann
2016-05-06 7:53 ` Sven Eckelmann
2016-05-08 16:33 ` Antonio Quartulli
2016-05-08 16:59 ` Sven Eckelmann
2016-05-15 9:01 ` Sven Eckelmann
2016-05-06 1:03 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506023434.GA16484@prodigo.lan \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.