From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: x86/platform/UV: Support UV4 socket address changes
Date: Fri, 06 May 2016 08:35:28 +0000 [thread overview]
Message-ID: <20160506083528.GA10231@mwanda> (raw)
Hello Mike Travis,
This is a semi-automatic email about new static checker warnings.
The patch 1de329c10d9f: "x86/platform/UV: Support UV4 socket address
changes" from Apr 29, 2016, leads to the following Smatch complaint:
arch/x86/kernel/apic/x2apic_uv_x.c:1201 decode_uv_systab()
error: we previously assumed 'st' could be null (see line 1199)
arch/x86/kernel/apic/x2apic_uv_x.c
1198 st = uv_systab;
1199 if ((!st || st->revision < UV_SYSTAB_VERSION_UV4) && !is_uv4_hub())
^^
New check for NULL.
1200 return;
1201 if (st->revision != UV_SYSTAB_VERSION_UV4_LATEST) {
^^^^^^^^^^^^
Unchecked dereference in the is_uv4_hub() case. Perhaps the parenthesis
are not in the right place or the check for NULL can be removed?
1202 pr_crit(
1203 "UV: BIOS UVsystab version(%x) mismatch, expecting(%x)\n",
regards,
dan carpenter
reply other threads:[~2016-05-06 8:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506083528.GA10231@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.