Re: [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2590 bytes --]

On Fri, May 06, 2016 at 10:16:18AM +0000, Ahsan, Noor wrote:
> Doesn't recipe name is mentioned when only that recipe is changed in the patch. I though when multiple recipes are changed then we don't mention the name of the files in the commit summary. Correct me if my interpretation is wrong.

Listing 2 is short enough, so the summary should start with them, just
like in the commit where I've blacklisted them:

  libnice, farsight2, pidgin: Blacklist because libnice's nice.pc

> Secondly I thought both are inter related. That is why added both in signed patch. Farsight is mentioned in the details 

I'm fine with farsight unblacklisted in the same commit as the reason
for blacklist is the same and resolved here. Just remove added blank
lines as well please.

> Remove PNBLACKLIST for libnice and farsight recipes.
> 
> Noor
> 
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Christopher Larson
> Sent: Thursday, May 05, 2016 10:05 PM
> To: Openembedded Discussion
> Subject: Re: [oe] [PATCH] Fix "failed sanity test tmpdir" for libnice and update PNBLACKLIST.
> 
> On Thu, May 5, 2016 at 9:22 AM, Noor, Ahsan <noor_ahsan@mentor.com> wrote:
> 
> > From: Noor Ahsan <noor_ahsan@mentor.com>
> >
> > * Update do_compile_append where it was updating *.pc from ${S} and
> >   removing staging dir folder. Now we have seperate build folder
> >   where packages got build. We have to search pc in ${B} not in ${S}.
> >   After updating the tmp dir pathc is removed from nice.pc file.
> > * Remove PNBLACKLIST for libnice and farsight recipes.
> >
> > Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> >
> 
> The commit message doesn't meet the OE guidelines (not prefixed by the recipe being changed) and you don't mention farsight2 in the message at all
> -- should that be a separate commit?
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]