From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4 1/4] drm: Add helper for DP++ adaptors Date: Fri, 6 May 2016 16:10:09 +0300 Message-ID: <20160506131009.GA4329@intel.com> References: <1462287356-5893-1-git-send-email-ville.syrjala@linux.intel.com> <1462298189-14255-1-git-send-email-ville.syrjala@linux.intel.com> <1462538270.14511.13.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id CC60E6EABC for ; Fri, 6 May 2016 13:11:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1462538270.14511.13.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Zanoni, Paulo R" Cc: "daniel.vetter@ffwll.ch" , "intel-gfx@lists.freedesktop.org" , "tore@fud.no" , "stable@vger.kernel.org" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXkgMDYsIDIwMTYgYXQgMTI6Mzc6NTFQTSArMDAwMCwgWmFub25pLCBQYXVsbyBS IHdyb3RlOgo+IEVtIFRlciwgMjAxNi0wNS0wMyDDoHMgMjA6NTYgKzAzMDAsIHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tCj4gZXNjcmV2ZXU6CjxzbmlwPgo+ID4gKwo+ID4gKy8qKgo+ID4g KyAqIGRybV9kcF9kdWFsX21vZGVfcmVhZCAtIFJlYWQgZnJvbSB0aGUgRFAgZHVhbCBtb2RlIGFk YXB0b3IKPiA+IHJlZ2lzdGVyKHMpCj4gPiArICogQGFkYXB0ZXI6IEkyQyBhZGFwdGVyIGZvciB0 aGUgRERDIGJ1cwo+ID4gKyAqIEBvZmZzZXQ6IHJlZ2lzdGVyIG9mZnNldAo+ID4gKyAqIEBidWZm ZXI6IGJ1ZmZlciBmb3IgcmV0dXJuIGRhdGEKPiA+ICsgKiBAc2l6ZTogc2l6byBvZiB0aGUgYnVm ZmVyCj4gPiArICoKPiA+ICsgKiBSZWFkcyBAc2l6ZSBieXRlcyBmcm9tIHRoZSBEUCBkdWFsIG1v ZGUgYWRhcHRvciByZWdpc3RlcnMKPiA+ICsgKiBzdGFydGluZyBhdCBAb2Zmc2V0Lgo+ID4gKyAq Cj4gPiArICogUmV0dXJuczoKPiA+ICsgKiAwIG9uIHN1Y2Nlc3MsIG5lZ2F0aXZlIGVycm9yIGNv ZGUgb24gZmFpbHVyZQo+ID4gKyAqLwo+ID4gK3NzaXplX3QgZHJtX2RwX2R1YWxfbW9kZV9yZWFk KHN0cnVjdCBpMmNfYWRhcHRlciAqYWRhcHRlciwKPiA+ICsJCQnCoMKgwqDCoMKgwqB1OCBvZmZz ZXQsIHZvaWQgKmJ1ZmZlciwgc2l6ZV90IHNpemUpCj4gPiArewo+ID4gKwlzdHJ1Y3QgaTJjX21z ZyBtc2dzW10gPSB7Cj4gPiArCQl7Cj4gPiArCQkJLmFkZHIgPSBEUF9EVUFMX01PREVfU0xBVkVf QUREUkVTUywKPiA+ICsJCQkuZmxhZ3MgPSAwLAo+ID4gKwkJCS5sZW4gPSAxLAo+ID4gKwkJCS5i dWYgPSAmb2Zmc2V0LAo+ID4gKwkJfSwKPiA+ICsJCXsKPiA+ICsJCQkuYWRkciA9IERQX0RVQUxf TU9ERV9TTEFWRV9BRERSRVNTLAo+ID4gKwkJCS5mbGFncyA9IEkyQ19NX1JELAo+ID4gKwkJCS5s ZW4gPSBzaXplLAo+ID4gKwkJCS5idWYgPSBidWZmZXIsCj4gPiArCQl9LAo+ID4gKwl9Owo+ID4g KwlpbnQgcmV0Owo+ID4gKwo+ID4gKwlyZXQgPSBpMmNfdHJhbnNmZXIoYWRhcHRlciwgbXNncywg QVJSQVlfU0laRShtc2dzKSk7Cj4gPiArCWlmIChyZXQgPCAwKQo+ID4gKwkJcmV0dXJuIHJldDsK PiA+ICsJaWYgKHJldCAhPSBBUlJBWV9TSVpFKG1zZ3MpKQo+ID4gKwkJcmV0dXJuIC1FUFJPVE87 Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ID4gK30KPiBFWFBPUlRfU1lNQk9MKGRybV9kcF9kdWFs X21vZGVfcmVhZCk7Cj4gCj4gKG9yIG1ha2UgaXQgc3RhdGljIGFuZCByZW1vdmUgZnJvbSB0aGUg LmggZmlsZSkKCkhtbS4gTXkgaW5pdGlhbCBpZGVhIHdhcyB0aGF0IHNvbWVvbmUgbWlnaHQgd2Fu dCB0byB1c2UgdGhlc2UgZm9yIGRlYnVnCmFuZC9vciBhY2Nlc3Npbmcgc29tZSB2ZW5kb3Igc3Bl Y2lmaWMgcmVnaXN0ZXIgYW5kIHdoYXRub3QuIFdoaWNoIGlzIHdoeQpJIG1lYW50IHRvIGV4cG9y dCB0aGVtIChhbmQgc29tZWhvdyBmYWlsZWQgaW4gdGhpcyBjYXNlKS4gSSBndWVzcyBJCnN0aWxs IHN0YW5kIGJ5IHRoYXQgcmVhc29uaW5nLCBhbHRob3VnaCByaWdodCBub3cgd2UgaGF2ZSBubyB1 c2VycwpvdXRzaWRlIHRoaXMgZmlsZS4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:40554 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbcEFNME (ORCPT ); Fri, 6 May 2016 09:12:04 -0400 Date: Fri, 6 May 2016 16:10:09 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Zanoni, Paulo R" Cc: "intel-gfx@lists.freedesktop.org" , "tore@fud.no" , "Sharma, Shashank" , "stable@vger.kernel.org" , "daniel.vetter@ffwll.ch" Subject: Re: [PATCH v4 1/4] drm: Add helper for DP++ adaptors Message-ID: <20160506131009.GA4329@intel.com> References: <1462287356-5893-1-git-send-email-ville.syrjala@linux.intel.com> <1462298189-14255-1-git-send-email-ville.syrjala@linux.intel.com> <1462538270.14511.13.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1462538270.14511.13.camel@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, May 06, 2016 at 12:37:51PM +0000, Zanoni, Paulo R wrote: > Em Ter, 2016-05-03 �s 20:56 +0300, ville.syrjala@linux.intel.com > escreveu: > > + > > +/** > > + * drm_dp_dual_mode_read - Read from the DP dual mode adaptor > > register(s) > > + * @adapter: I2C adapter for the DDC bus > > + * @offset: register offset > > + * @buffer: buffer for return data > > + * @size: sizo of the buffer > > + * > > + * Reads @size bytes from the DP dual mode adaptor registers > > + * starting at @offset. > > + * > > + * Returns: > > + * 0 on success, negative error code on failure > > + */ > > +ssize_t drm_dp_dual_mode_read(struct i2c_adapter *adapter, > > + ������u8 offset, void *buffer, size_t size) > > +{ > > + struct i2c_msg msgs[] = { > > + { > > + .addr = DP_DUAL_MODE_SLAVE_ADDRESS, > > + .flags = 0, > > + .len = 1, > > + .buf = &offset, > > + }, > > + { > > + .addr = DP_DUAL_MODE_SLAVE_ADDRESS, > > + .flags = I2C_M_RD, > > + .len = size, > > + .buf = buffer, > > + }, > > + }; > > + int ret; > > + > > + ret = i2c_transfer(adapter, msgs, ARRAY_SIZE(msgs)); > > + if (ret < 0) > > + return ret; > > + if (ret != ARRAY_SIZE(msgs)) > > + return -EPROTO; > > + > > + return 0; > > +} > EXPORT_SYMBOL(drm_dp_dual_mode_read); > > (or make it static and remove from the .h file) Hmm. My initial idea was that someone might want to use these for debug and/or accessing some vendor specific register and whatnot. Which is why I meant to export them (and somehow failed in this case). I guess I still stand by that reasoning, although right now we have no users outside this file. -- Ville Syrj�l� Intel OTC