From: Phil Sutter <phil@nwl.cc>
To: Edward Cree <ecree@solarflare.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev <netdev@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH iproute2] geneve: fix IPv6 remote address reporting
Date: Fri, 6 May 2016 16:43:45 +0200 [thread overview]
Message-ID: <20160506144345.GC11058@orbyte.nwl.cc> (raw)
In-Reply-To: <572CAA09.302@solarflare.com>
On Fri, May 06, 2016 at 03:28:25PM +0100, Edward Cree wrote:
> Since we can only configure unicast, we probably want to be able to
> display unicast, rather than multicast.
Furthermore, the kernel even rejects multicast peer addresses.
> I'm assuming this is what was intended, but tbh I don't know why we
> need to check for multicast on the display side at all, rather than
> just displaying whatever the kernel gives us.
Why do you then propose a dubious fix to a dubious check instead of
getting rid of it in the first place? Reminds me a bit of this here (no
offense intended):
http://geekandpoke.typepad.com/geekandpoke/2011/07/good-coders.html
Cheers, Phil
next prev parent reply other threads:[~2016-05-06 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 14:28 [PATCH iproute2] geneve: fix IPv6 remote address reporting Edward Cree
2016-05-06 14:43 ` Phil Sutter [this message]
2016-05-06 15:14 ` Edward Cree
2016-05-06 15:28 ` Phil Sutter
2016-05-13 21:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506144345.GC11058@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=ecree@solarflare.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.