From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/5] block: make bio_inc_remaining() interface accessible again
Date: Fri, 6 May 2016 18:43:02 +0200 [thread overview]
Message-ID: <20160506164302.GA8332@lst.de> (raw)
In-Reply-To: <20160506161915.GA905@redhat.com>
Ok, I think I understand the problem now - the problem is when
break_up_discard_bio does not actually call pool->process_prepared
_discard directly, but instead defers it to a worker thread. At that
point we might have already completed all the chained bios and
the original one by the time we run another instance of
process_discard_cell_passdown.
So I guess we'll have to live with this for now. I really don't
like it very much, and the comments could use a massive improvement,
but instead of duplicating the code let's just export the helper:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-05-06 16:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 15:54 [PATCH 0/5] dm thin: adapt code to use new async __blkdev_issue_discard Mike Snitzer
2016-05-05 15:54 ` [PATCH v2 1/5] block: reinstate early return of -EOPNOTSUPP from blkdev_issue_discard Mike Snitzer
2016-05-06 16:04 ` Christoph Hellwig
2016-05-05 15:54 ` [PATCH 2/5] block: make bio_inc_remaining() interface accessible again Mike Snitzer
2016-05-06 15:25 ` Christoph Hellwig
2016-05-06 15:56 ` Christoph Hellwig
2016-05-06 16:19 ` Mike Snitzer
2016-05-06 16:27 ` Christoph Hellwig
2016-05-06 16:46 ` Joe Thornber
2016-05-06 16:30 ` Joe Thornber
2016-05-06 16:43 ` Christoph Hellwig [this message]
2016-05-06 15:57 ` Mike Snitzer
2016-05-05 15:54 ` [PATCH 3/5] dm thin: remove __bio_inc_remaining() and switch to using bio_inc_remaining() Mike Snitzer
2016-05-05 15:54 ` [PATCH 4/5] dm thin: use __blkdev_issue_discard for async discard support Mike Snitzer
2016-05-06 16:05 ` Christoph Hellwig
2016-05-05 15:54 ` [PATCH 5/5] dm thin: unroll issue_discard() to create longer discard bio chains Mike Snitzer
2016-05-06 16:12 ` Christoph Hellwig
2016-05-06 16:36 ` Joe Thornber
2016-05-06 16:44 ` Christoph Hellwig
2016-05-06 16:48 ` Joe Thornber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506164302.GA8332@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.