All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bruno Carvalho <brunocarvalhofarias@gmail.com>
Cc: ciorneiioana@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, shivanib134@gmail.com,
	tj@kernel.org, s.demeszko@wireless-instruments.com,
	bhumirks@gmail.com
Subject: Re: [PATCH] staging: gdm724x: fixing coding style problems listed by checkpatch
Date: Fri, 6 May 2016 23:29:46 -0400	[thread overview]
Message-ID: <20160507032946.GA10607@kroah.com> (raw)
In-Reply-To: <1462574792-4672-1-git-send-email-brunocarvalhofarias@gmail.com>

On Fri, May 06, 2016 at 06:46:32PM -0400, Bruno Carvalho wrote:
> This patch is to fix some coding style issues pointed
> by scripts/checkpatch.pl

Which ones specifically?

Please be descriptive, as other commits are for this driver, take a look
at them for examples.

And remember, only do one "type" of change per patch, don't mix us a
bunch of different types of coding style cleanups in the same patch.

Please fix this up and resend.

thanks,

greg k-h

      reply	other threads:[~2016-05-07  3:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 22:46 [PATCH] staging: gdm724x: fixing coding style problems listed by checkpatch Bruno Carvalho
2016-05-07  3:29 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160507032946.GA10607@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhumirks@gmail.com \
    --cc=brunocarvalhofarias@gmail.com \
    --cc=ciorneiioana@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.demeszko@wireless-instruments.com \
    --cc=shivanib134@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.