From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: l3mdev: Add hook in ip and ipv6
Date: Sun, 8 May 2016 08:44:40 +0300 [thread overview]
Message-ID: <20160508084440.49a6865a@halley> (raw)
In-Reply-To: <572EA3A4.9010200@cumulusnetworks.com>
Hi,
On Sat, 7 May 2016 20:25:40 -0600 David Ahern <dsa@cumulusnetworks.com> wrote:
> > - On which circumstances we end up entering
> > l3mdev_ip_rcv/l3mdev_ip6_rcv where skb->dev is the master?
> > If I got it right, we enter 'ip_rcv_finish' on a slave device,
> > the callback is invoked and eventually sets skb->dev and skb->skb_iif
> > to the VRF device; then ip_rcv_finish continues processing the
> > altered skb (with the changed skb->dev).
> > So on which cicumstances do we enter 'ip_rcv_finish' where the
> > skb->dev is ALREADY a master device?
>
> If you look at the full patchset I posted on 5/4 the patch after PKTINFO
> allows local traffic. That change needs the netif_is_l3_master().
I see. Thanks David.
next prev parent reply other threads:[~2016-05-08 5:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 1:49 [PATCH net-next v2 0/2] net: vrf: Fixup PKTINFO to return enslaved device index David Ahern
2016-05-07 1:49 ` [PATCH net-next v2 1/2] net: l3mdev: Add hook in ip and ipv6 David Ahern
2016-05-07 8:30 ` Shmulik Ladkani
2016-05-07 14:50 ` David Ahern
2016-05-07 18:32 ` Shmulik Ladkani
2016-05-08 2:25 ` David Ahern
2016-05-08 5:44 ` Shmulik Ladkani [this message]
2016-05-07 1:49 ` [PATCH net-next 2/2] net: original ingress device index in PKTINFO David Ahern
2016-05-07 8:41 ` Shmulik Ladkani
2016-05-07 14:53 ` David Ahern
2016-05-07 19:08 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160508084440.49a6865a@halley \
--to=shmulik.ladkani@gmail.com \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.