From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] virtio: split virtio rx/tx queue Date: Sun, 8 May 2016 22:14:38 -0700 Message-ID: <20160509051438.GZ5641@yliu-dev.sh.intel.com> References: <1462323027-91942-1-git-send-email-huawei.xie@intel.com> <20160505000327.GT5641@yliu-dev.sh.intel.com> <20160505030704.GU5641@yliu-dev.sh.intel.com> <20160505035000.GY5641@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" To: "Xie, Huawei" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 78A374AAD for ; Mon, 9 May 2016 07:10:11 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 05, 2016 at 05:29:27AM +0000, Xie, Huawei wrote: > What I mean is firstly we split the queue, without breaking the common > setup; then introduce RX/TX specific setup calling extracted common > setup, so we don't have a chance to introduce duplicated code. In such way, you have actually introduced duplicated code, haven't you? You may argue, "yes, but I will fix it in a later patch." This is to introducing a build error and fixing it later to me. --yliu