From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azdf2-0002If-Jl for qemu-devel@nongnu.org; Mon, 09 May 2016 01:23:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azdey-0002CU-8k for qemu-devel@nongnu.org; Mon, 09 May 2016 01:23:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azdey-0002Bq-2q for qemu-devel@nongnu.org; Mon, 09 May 2016 01:23:12 -0400 Date: Mon, 9 May 2016 13:23:03 +0800 From: Peter Xu Message-ID: <20160509052303.GH4100@pxdev.xzpeter.org> References: <1462418761-12714-1-git-send-email-peterx@redhat.com> <1462418761-12714-23-git-send-email-peterx@redhat.com> <572B13EF.406@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <572B13EF.406@web.de> Subject: Re: [Qemu-devel] [PATCH v6 22/26] x86-iommu: replace existing VT-d hooks into X86 ones List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org, imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com, jasowang@redhat.com, marcel@redhat.com, mst@redhat.com, pbonzini@redhat.com, rkrcmar@redhat.com, alex.williamson@redhat.com, wexu@redhat.com, davidkiarie4@gmail.com On Thu, May 05, 2016 at 11:35:43AM +0200, Jan Kiszka wrote: > On 2016-05-05 05:25, Peter Xu wrote: > > Previously, there are lots of VT-d hooks in common codes (like q35, > > ioapic, etc.). A better way is to avoid using VT-d interfaces. Also, we > > can start to abstract some common functions between Intel and future AMD > > IOMMU device. > > Just don't introduce the VT-d variants in the first place. Will also > shorten your patch series again. Yes, I can do that. After waiting for some more review comments and making sure this is the correct way to go, I can do the re-arrangement in next version. Thanks, -- peterx