From: Peter Zijlstra <peterz@infradead.org>
To: Zhou Chengming <zhouchengming1@huawei.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
guohanjun@huawei.com, huawei.libin@huawei.com
Subject: Re: [PATCH] sched: fix the calculation of __sched_period in sched_slice()
Date: Mon, 9 May 2016 09:05:02 +0200 [thread overview]
Message-ID: <20160509070502.GA3430@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1462761957-36259-1-git-send-email-zhouchengming1@huawei.com>
On Mon, May 09, 2016 at 10:45:57AM +0800, Zhou Chengming wrote:
> When we get the sched_slice of a sched_entity, we use cfs_rq->nr_running
> to calculate the whole __sched_period. But cfs_rq->nr_running is the
> number of sched_entity in that cfs_rq, rq->nr_running is the number
> of all the tasks that are not throttled. So we should use the
> rq->nr_running to calculate the whole __sched_period value.
No, this was very much on purpose.
prev parent reply other threads:[~2016-05-09 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 2:45 [PATCH] sched: fix the calculation of __sched_period in sched_slice() Zhou Chengming
2016-05-09 7:05 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509070502.GA3430@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=guohanjun@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.