From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C550C1A1EDF for ; Mon, 9 May 2016 01:31:29 -0700 (PDT) Date: Mon, 9 May 2016 10:31:25 +0200 From: Jan Kara Subject: Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount Message-ID: <20160509083125.GC11897@quack2.suse.cz> References: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com> <1462494596-20938-5-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1462494596-20938-5-git-send-email-toshi.kani@hpe.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Toshi Kani Cc: hch@infradead.org, jack@suse.cz, linux-nvdimm@lists.01.org, david@fromorbit.com, linux-kernel@vger.kernel.org, micah.parrish@hpe.com, axboe@fb.com, adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, tytso@mit.edu List-ID: On Thu 05-05-16 18:29:55, Toshi Kani wrote: > When a partition is not aligned by 4KB, mount -o dax succeeds, > but any read/write access to the filesystem fails, except for > metadata update. > > Call bdev_supports_dax() to perform proper precondition checks > which includes this partition alignment check. > > Signed-off-by: Toshi Kani > Cc: Jan Kara > Cc: Dan Williams > Cc: Ross Zwisler > Cc: Christoph Hellwig > Cc: Boaz Harrosh Looks good to me. Since this patch depends on the first two in your series, just feel free to add: Reviewed-by: Jan Kara and merge it along with other patches. I've removed the ext2 patch from the previous version from my tree. Honza -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:48007 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbcEIIba (ORCPT ); Mon, 9 May 2016 04:31:30 -0400 Date: Mon, 9 May 2016 10:31:25 +0200 From: Jan Kara To: Toshi Kani Cc: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com, viro@zeniv.linux.org.uk, axboe@fb.com, hch@infradead.org, boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com, micah.parrish@hpe.com, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount Message-ID: <20160509083125.GC11897@quack2.suse.cz> References: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com> <1462494596-20938-5-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462494596-20938-5-git-send-email-toshi.kani@hpe.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 05-05-16 18:29:55, Toshi Kani wrote: > When a partition is not aligned by 4KB, mount -o dax succeeds, > but any read/write access to the filesystem fails, except for > metadata update. > > Call bdev_supports_dax() to perform proper precondition checks > which includes this partition alignment check. > > Signed-off-by: Toshi Kani > Cc: Jan Kara > Cc: Dan Williams > Cc: Ross Zwisler > Cc: Christoph Hellwig > Cc: Boaz Harrosh Looks good to me. Since this patch depends on the first two in your series, just feel free to add: Reviewed-by: Jan Kara and merge it along with other patches. I've removed the ext2 patch from the previous version from my tree. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbcEIIbb (ORCPT ); Mon, 9 May 2016 04:31:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:48007 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbcEIIba (ORCPT ); Mon, 9 May 2016 04:31:30 -0400 Date: Mon, 9 May 2016 10:31:25 +0200 From: Jan Kara To: Toshi Kani Cc: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com, viro@zeniv.linux.org.uk, axboe@fb.com, hch@infradead.org, boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com, micah.parrish@hpe.com, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] ext2: Add alignment check for DAX mount Message-ID: <20160509083125.GC11897@quack2.suse.cz> References: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com> <1462494596-20938-5-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462494596-20938-5-git-send-email-toshi.kani@hpe.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 05-05-16 18:29:55, Toshi Kani wrote: > When a partition is not aligned by 4KB, mount -o dax succeeds, > but any read/write access to the filesystem fails, except for > metadata update. > > Call bdev_supports_dax() to perform proper precondition checks > which includes this partition alignment check. > > Signed-off-by: Toshi Kani > Cc: Jan Kara > Cc: Dan Williams > Cc: Ross Zwisler > Cc: Christoph Hellwig > Cc: Boaz Harrosh Looks good to me. Since this patch depends on the first two in your series, just feel free to add: Reviewed-by: Jan Kara and merge it along with other patches. I've removed the ext2 patch from the previous version from my tree. Honza -- Jan Kara SUSE Labs, CR