From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/2] mfd: wm5110: ARIZONA_CLOCK_CONTROL should be volatile Date: Mon, 9 May 2016 12:16:47 +0100 Message-ID: <20160509111647.GH8324@dell> References: <1461686780-22885-1-git-send-email-rf@opensource.wolfsonmicro.com> <1461686780-22885-2-git-send-email-rf@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by alsa0.perex.cz (Postfix) with ESMTP id 561C82606F5 for ; Mon, 9 May 2016 13:16:36 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id e201so132560515wme.0 for ; Mon, 09 May 2016 04:16:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1461686780-22885-2-git-send-email-rf@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Richard Fitzgerald Cc: alsa-devel@alsa-project.org, broonie@kernel.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org T24gVHVlLCAyNiBBcHIgMjAxNiwgUmljaGFyZCBGaXR6Z2VyYWxkIHdyb3RlOgoKPiBTb21lIG9m IHRoZSBiaXRzIGluIHRoaXMgcmVnaXN0ZXIgY2FuIGJlIGNoYW5nZWQgYnkgdGhlIGNvZGVjCj4g c28gd2UgbXVzdCBtYXJrIGl0IHZvbGF0aWxlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJpY2hhcmQg Rml0emdlcmFsZCA8cmZAb3BlbnNvdXJjZS53b2xmc29ubWljcm8uY29tPgo+IC0tLQo+ICBkcml2 ZXJzL21mZC93bTUxMTAtdGFibGVzLmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspCgpBcHBsaWVkLCB0aGFua3MuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC93bTUx MTAtdGFibGVzLmMgYi9kcml2ZXJzL21mZC93bTUxMTAtdGFibGVzLmMKPiBpbmRleCA4ZTc0ZTcx Li4xZWU2OGJkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL3dtNTExMC10YWJsZXMuYwo+ICsr KyBiL2RyaXZlcnMvbWZkL3dtNTExMC10YWJsZXMuYwo+IEBAIC0zMDY2LDYgKzMwNjYsNyBAQCBz dGF0aWMgYm9vbCB3bTUxMTBfdm9sYXRpbGVfcmVnaXN0ZXIoc3RydWN0IGRldmljZSAqZGV2LCB1 bnNpZ25lZCBpbnQgcmVnKQo+ICAJY2FzZSBBUklaT05BX0FPRF9JUlFfUkFXX1NUQVRVUzoKPiAg CWNhc2UgQVJJWk9OQV9GWF9DVFJMMjoKPiAgCWNhc2UgQVJJWk9OQV9BU1JDX1NUQVRVUzoKPiAr CWNhc2UgQVJJWk9OQV9DTE9DS19DT05UUk9MOgo+ICAJY2FzZSBBUklaT05BX0RTUF9TVEFUVVM6 Cj4gIAljYXNlIEFSSVpPTkFfRFNQMV9TVEFUVVNfMToKPiAgCWNhc2UgQVJJWk9OQV9EU1AxX1NU QVRVU18yOgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcg VGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0 CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qu b3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbcEILQi (ORCPT ); Mon, 9 May 2016 07:16:38 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:38555 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbcEILQh (ORCPT ); Mon, 9 May 2016 07:16:37 -0400 Date: Mon, 9 May 2016 12:16:47 +0100 From: Lee Jones To: Richard Fitzgerald Cc: broonie@kernel.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 1/2] mfd: wm5110: ARIZONA_CLOCK_CONTROL should be volatile Message-ID: <20160509111647.GH8324@dell> References: <1461686780-22885-1-git-send-email-rf@opensource.wolfsonmicro.com> <1461686780-22885-2-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461686780-22885-2-git-send-email-rf@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Apr 2016, Richard Fitzgerald wrote: > Some of the bits in this register can be changed by the codec > so we must mark it volatile. > > Signed-off-by: Richard Fitzgerald > --- > drivers/mfd/wm5110-tables.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c > index 8e74e71..1ee68bd 100644 > --- a/drivers/mfd/wm5110-tables.c > +++ b/drivers/mfd/wm5110-tables.c > @@ -3066,6 +3066,7 @@ static bool wm5110_volatile_register(struct device *dev, unsigned int reg) > case ARIZONA_AOD_IRQ_RAW_STATUS: > case ARIZONA_FX_CTRL2: > case ARIZONA_ASRC_STATUS: > + case ARIZONA_CLOCK_CONTROL: > case ARIZONA_DSP_STATUS: > case ARIZONA_DSP1_STATUS_1: > case ARIZONA_DSP1_STATUS_2: -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog