All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: Marius Vlad <marius.c.vlad@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.
Date: Mon, 9 May 2016 16:25:40 +0100	[thread overview]
Message-ID: <20160509152539.GA14754@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1462800224-29338-1-git-send-email-marius.c.vlad@intel.com>

On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote:
> Easier to catch compilation errors.


Having -Werror by default is a no go as you cannot control/predict the
set of warnings (and the quality of those) of all previous and future
gcc/clang versions.

Always using this flag will cause distributions to hate us.

Adding a test (with patchwork integration!) that ensures each commit
posted on this mailing-list compiles without new warning with a chosen
toolchain (and even passes distcheck!) would be nice.

-- 
Damien

> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> ---
>  benchmarks/Makefile.am | 2 +-
>  demos/Makefile.am      | 3 ++-
>  overlay/Makefile.am    | 3 ++-
>  tests/Makefile.am      | 2 +-
>  tools/Makefile.am      | 4 +++-
>  5 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am
> index 2c2d100..46992f8 100644
> --- a/benchmarks/Makefile.am
> +++ b/benchmarks/Makefile.am
> @@ -2,7 +2,7 @@
>  include Makefile.sources
>  
>  AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -Werror
>  LDADD = $(top_builddir)/lib/libintel_tools.la
>  
>  benchmarks_LTLIBRARIES = gem_exec_tracer.la
> diff --git a/demos/Makefile.am b/demos/Makefile.am
> index e6fbb3b..9eacd16 100644
> --- a/demos/Makefile.am
> +++ b/demos/Makefile.am
> @@ -3,5 +3,6 @@ bin_PROGRAMS = 				\
>  	$(NULL)
>  
>  AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
> +	    $(LIBUNWIND_CFLAGS) -Werror
>  LDADD = $(top_builddir)/lib/libintel_tools.la
> diff --git a/overlay/Makefile.am b/overlay/Makefile.am
> index c648875..ec68489 100644
> --- a/overlay/Makefile.am
> +++ b/overlay/Makefile.am
> @@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay
>  endif
>  
>  AM_CPPFLAGS = -I.
> -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS)
> +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \
> +	$(OVERLAY_CFLAGS) -Werror
>  LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS) $(OVERLAY_LIBS)
>  
>  intel_gpu_overlay_SOURCES = \
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 45e3359..22256ce 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\
>  	-include "$(srcdir)/../lib/check-ndebug.h" \
>  	-DIGT_SRCDIR=\""$(abs_srcdir)"\" \
>  	-DIGT_DATADIR=\""$(pkgdatadir)"\" \
> -	$(LIBUNWIND_CFLAGS) \
> +	$(LIBUNWIND_CFLAGS) -Werror \
>  	$(NULL)
>  
>  LDADD = ../lib/libintel_tools.la $(GLIB_LIBS)
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index df48d94..0ba1ff7 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -3,7 +3,9 @@ include Makefile.sources
>  SUBDIRS = null_state_gen registers
>  
>  AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib
> -AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\"
> +AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) \
> +	    $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \
> +	    -DPKGDATADIR=\"$(pkgdatadir)\" -Werror
>  LDADD = $(top_builddir)/lib/libintel_tools.la
>  AM_LDFLAGS = -Wl,--as-needed
>  
> -- 
> 2.8.0.rc3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-05-09 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 13:23 [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default Marius Vlad
2016-05-09 15:25 ` Damien Lespiau [this message]
2016-05-09 15:55   ` Marius Vlad
2016-05-09 15:57     ` Damien Lespiau
2016-05-09 16:01     ` Morton, Derek J
2016-05-10 14:32 ` [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add optional Werror Marius Vlad
2016-05-10 15:42   ` Damien Lespiau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160509152539.GA14754@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marius.c.vlad@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.