All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks
Date: Mon, 9 May 2016 19:27:15 +0300	[thread overview]
Message-ID: <20160509162715.GO4329@intel.com> (raw)
In-Reply-To: <df919693-3202-da0e-1a53-18684b0203d1@linux.intel.com>

On Wed, May 04, 2016 at 02:30:28PM +0200, Maarten Lankhorst wrote:
> Op 29-04-16 om 16:31 schreef ville.syrjala@linux.intel.com:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > When the crtc is enabled but !active, we should still compute the
> > watermarks as if the planes were visible. That would make it more
> > likely that the we can later transition to active without errors.
> >
> > Add a FIXME to remind people that we're doing the wrong thing now.
> > We should perhaps just move the wm computation for each individual plane
> > into the .check_plane hook, and later we'd just combine the results from
> > all active planes.
> For both patches:
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> 
> Not sure how much use there is to calculate watermarks for disabled planes, and then ignore them,
> but definitely something to keep in mind.

I guess you didn't read what I wrote? ;)

Series pushed to dinq. Thanks for the reviews.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-05-09 16:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 14:31 [PATCH 1/2] drm/i915: Calculate IPS linetime watermark based on future cdclk ville.syrjala
2016-04-29 14:31 ` [PATCH 2/2] drm/i915: Add a FIXME about crtc !active vs. watermarks ville.syrjala
2016-05-02  9:13   ` Daniel Vetter
2016-05-04 12:30   ` Maarten Lankhorst
2016-05-09 16:27     ` Ville Syrjälä [this message]
2016-04-29 16:24 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Calculate IPS linetime watermark based on future cdclk Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160509162715.GO4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.