From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azoJP-0005GG-Hb for qemu-devel@nongnu.org; Mon, 09 May 2016 12:45:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azoJN-0006Sw-8i for qemu-devel@nongnu.org; Mon, 09 May 2016 12:45:38 -0400 Date: Mon, 9 May 2016 17:45:26 +0100 From: "Daniel P. Berrange" Message-ID: <20160509164526.GH14467@redhat.com> Reply-To: "Daniel P. Berrange" References: <1460982107-4649-1-git-send-email-berrange@redhat.com> <1460982107-4649-4-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v8 3/3] block: enable testing of LUKS driver with block I/O tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf On Fri, May 06, 2016 at 03:32:15PM +0200, Max Reitz wrote: > On 18.04.2016 14:21, Daniel P. Berrange wrote: > > This adds support for testing the LUKS driver with the block > > I/O test framework. > > > > cd tests/qemu-io-tests > > ./check -luks > > > > A handful of test cases are modified to work with luks > > > > - 004 - whitelist luks format > > - 012 - use TEST_IMG_FILE instead of TEST_IMG for file ops > > - 048 - use TEST_IMG_FILE instead of TEST_IMG for file ops. > > don't assume extended image contents is all zeros, > > explicitly initialize with zeros > > Make file size smaller to avoid having to decrypt > > 1 GB of data. > > - 052 - don't assume initial image contents is all zeros, > > explicitly initialize with zeros > > - 100 - don't assume initial image contents is all zeros, > > explicitly initialize with zeros > > You're doing that with "write -P 0" in this patch. Would it be possible > to use "write -z" instead? Sure, I can switch that. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|