All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: Reverting ARCH_SUNXI arm64 support(?)
Date: Mon, 9 May 2016 22:57:16 +0200	[thread overview]
Message-ID: <20160509205716.GG3733@lukather> (raw)
In-Reply-To: <5730714C.7010608@arm.com>

On Mon, May 09, 2016 at 12:15:24PM +0100, Andre Przywara wrote:
> Hi,
> 
> On 09/05/16 10:09, Will Deacon wrote:
> > On Mon, May 09, 2016 at 09:53:11AM +0100, Andre Przywara wrote:
> >> Hi Will, Catalin,
> > 
> > Hi Andre,
> > 
> >> Suzuki reported a build failure with certain (non-defconfig) .configs
> >> due to the new ARCH_SUNXI support in 4.6-rc [1].
> >> As unfortunately we couldn't agree on a solution and also the support
> >> for the A64/Pine64 is partial in 4.6 anyway, can you please revert:
> >> ce3dd55b99b151a90ac1701c6825f2ae2d49b54e ("arm64: Introduce Allwinner
> >> SoC config option")
> > 
> > Given that we (Catalin and I) didn't commit that patch, it seems weird
> > that we should be reverting it. Shouldn't this be handled in arm-soc or
> > via the sunxi subtree?
> > 
> > We're also a week from the merge window, so it doesn't seem like a good
> > time to be hacking at .config/kconfig-related issues.
> 
> I agree, that's why I was proposing taking Suzuki's first patch:
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index efa77c1..521b1ec 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -2,6 +2,7 @@ menu "Platform selection"
> 
>  config ARCH_SUNXI
>  	bool "Allwinner sunxi 64-bit SoC Family"
> +	select GENERIC_IRQ_CHIP
>  	help
>  	  This enables support for Allwinner sunxi based SoCs like the A64.
> 
> 
> This is what defconfig selects anyway and also the change would be
> confined to this (new) config option.
> 
> Olof, Arnd: would it be an option to take this patch still?

FWIW, I'd be in favour for such patch as a late patch for 4.6.

We can always fix things up properly in a later patch for 4.7 or 4.8.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160509/6d3f1d45/attachment.sig>

  reply	other threads:[~2016-05-09 20:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09  8:53 Reverting ARCH_SUNXI arm64 support(?) Andre Przywara
2016-05-09  9:09 ` Will Deacon
2016-05-09 11:15   ` Andre Przywara
2016-05-09 20:57     ` Maxime Ripard [this message]
2016-05-09 21:03       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160509205716.GG3733@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.