From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b03Nb-0003hj-I9
	for qemu-devel@nongnu.org; Tue, 10 May 2016 04:51:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1b03NV-0006rZ-Pn
	for qemu-devel@nongnu.org; Tue, 10 May 2016 04:50:59 -0400
Date: Tue, 10 May 2016 09:50:41 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160510085041.GC13377@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1462848659-28659-1-git-send-email-famz@redhat.com>
	<20160510081425.GV1683@redhat.com>
	<20160510084303.GB28935@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160510084303.GB28935@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org, Max Reitz <mreitz@redhat.com>, John Snow <jsnow@redhat.com>

On Tue, May 10, 2016 at 09:43:04AM +0100, Richard W.M. Jones wrote:
> On Tue, May 10, 2016 at 09:14:26AM +0100, Richard W.M. Jones wrote:
> > However I didn't test the write-shareable case (the libvirt
> > <shareable/> flag which should map to a shared lock -- is that right Dan?).
> 
> To Dan (mainly): I think setting the <shareable/> flag in libvirt only
> sets cache=unsafe on the qemu drive (it may have other effects for
> virtlockd).  Should there be an extra qemu drive flag to communicate
> that the drive is write-shareable?

Sure, if QEMU had a way to indicate that the disk was used in a
write-sharable mode, libvirt would use it.

I agree with your general point that we should do no locking for
read-only access, F_RDLCK for shared-write and F_WRLCK for
exclusive-write access. I think I made that point similarly against
an earlier version of this patchset

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|