From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b06Vr-0001Ti-C6 for qemu-devel@nongnu.org; Tue, 10 May 2016 08:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b06Vo-0005BS-V1 for qemu-devel@nongnu.org; Tue, 10 May 2016 08:11:42 -0400 Date: Tue, 10 May 2016 13:11:30 +0100 From: "Richard W.M. Jones" Message-ID: <20160510121130.GA1683@redhat.com> References: <20160510085041.GC13377@redhat.com> <20160510091422.GG4921@noname.str.redhat.com> <20160510092338.GG13377@redhat.com> <20160510093514.GH4921@noname.str.redhat.com> <20160510094310.GH13377@redhat.com> <20160510100706.GJ4921@noname.str.redhat.com> <20160510101612.GY1683@redhat.com> <20160510110849.GK4921@noname.str.redhat.com> <20160510114615.GZ1683@redhat.com> <20160510120102.GM4921@noname.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160510120102.GM4921@noname.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: "Daniel P. Berrange" , Fam Zheng , qemu-block@nongnu.org, Jeff Cody , Markus Armbruster , qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org, Max Reitz , John Snow At no point did I say that it was safe to use libguestfs on live VMs or that you would always get consistent data out. But the fact that it can fail is understood, the chance of failure is really tiny (it has literally only happened twice that I've read corrupted data, in years of daily use), and the operation is very useful. So I think this patch series should either not lock r/o VMs, or should add a nolock flag to override the locking (which libguestfs will always use). That's all I have to say on this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW