From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH v3 9/9] run_tests: log stderr
Date: Tue, 10 May 2016 14:47:31 +0200 [thread overview]
Message-ID: <20160510124731.GD12472@potion> (raw)
In-Reply-To: <5731C8F9.3020204@redhat.com>
2016-05-10 13:41+0200, Paolo Bonzini:
> On 15/04/2016 22:52, Radim Krčmář wrote:
>> echo "exec {stdout}>&1"
>> echo "RUNTIME_log_stdout='>(cat >&\$stdout)'"
>> + echo "RUNTIME_log_stderr=>(cat >&2)"
>>
>> cat scripts/runtime.bash
>>
>> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
>> index fc4be91d8727..ff2d98b547b5 100644
>> --- a/scripts/runtime.bash
>> +++ b/scripts/runtime.bash
>> @@ -61,7 +61,8 @@ function run()
>>
>> # extra_params in the config file may contain backticks that need to be
>> # expanded, so use eval to start qemu. Same for $RUNTIME_log_stdout.
>> - summary=$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout" | extract_summary))
>> + summary=$(eval $cmdline > >(eval "tee -a $RUNTIME_log_stdout" | extract_summary) \
>> + 2>> $RUNTIME_log_stderr)
>
> Whoa, so this uses the outer eval?
No, RUNTIME_log_stderr is evaluated only at the time of definition,
which makes it inconsistent with RUNTIME_log_stdout.
> Perhaps the 2>> should move before
> the >.
I will drop this patch ... it's too insane and Drew liked stderr in
./run_tests.sh output. Sorry.
next prev parent reply other threads:[~2016-05-10 12:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 20:52 [PATCH kvm-unit-tests v3 0/9] Improve the output of test runners Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 1/9] lib/report: allow test skipping Radim Krčmář
2016-04-19 6:26 ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 2/9] x86/*: report skipped tests Radim Krčmář
2016-04-19 6:34 ` Andrew Jones
2016-04-19 11:51 ` Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 3/9] x86/unittests: remove svm-disabled Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 4/9] x86/pmu: expect failure with nmi_watchdog Radim Krčmář
2016-04-19 6:44 ` Andrew Jones
2016-04-19 11:57 ` Radim Krčmář
2016-04-19 13:46 ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 5/9] lib/report: don't print 0 failed tests Radim Krčmář
2016-04-19 6:45 ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 6/9] scripts/runtime: skip tests that cannot run Radim Krčmář
2016-04-19 7:01 ` Andrew Jones
2016-04-19 12:01 ` Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 7/9] scripts/runtime: consolidate summary tags Radim Krčmář
2016-04-19 7:04 ` Andrew Jones
2016-04-15 20:52 ` [PATCH v3 8/9] run_tests: print summary Radim Krčmář
2016-04-19 7:19 ` Andrew Jones
2016-05-10 11:45 ` Paolo Bonzini
2016-05-10 12:41 ` Radim Krčmář
2016-05-10 14:32 ` Paolo Bonzini
2016-05-10 15:31 ` Radim Krčmář
2016-05-10 15:46 ` Paolo Bonzini
2016-05-10 16:17 ` Radim Krčmář
2016-04-15 20:52 ` [PATCH v3 9/9] run_tests: log stderr Radim Krčmář
2016-04-19 7:26 ` Andrew Jones
2016-04-19 12:13 ` Radim Krčmář
2016-05-10 11:41 ` Paolo Bonzini
2016-05-10 12:47 ` Radim Krčmář [this message]
2016-04-19 7:31 ` [PATCH kvm-unit-tests v3 0/9] Improve the output of test runners Andrew Jones
2016-04-19 12:14 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510124731.GD12472@potion \
--to=rkrcmar@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.