diff for duplicates of <20160510132055.GU2890@piout.net> diff --git a/a/1.txt b/N1/1.txt index cee34fe..e3693c5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,10 +4,10 @@ Again, please use checkpatch.pl --strict before sending a patch. On 06/05/2016 at 02:16:04 -0700, venkat.prashanth2498@gmail.com wrote : > From: venkat-prashanth <venkat.prashanth2498@gmail.com> ->=20 -> This is a patch to add=20 +> +> This is a patch to add > support for maxim rtc MAX6916 ->=20 +> > Signed-off-by : Venkat Prashanth B U <venkat.prashanth2498@gmail.com> > --- @@ -15,13 +15,12 @@ The changelog should appear here, not in a separate file. > Kconfig | 10 ++++ > changeLOG | 36 ++++++++++++ -> rtc-max6916.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++= -++++++ +> rtc-max6916.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ You are missing modifications in the Makefile. > 3 files changed, 218 insertions(+) ->=20 +> > diff --git a/drivers/rtcKconfig b/drivers/rtc/Kconfig > index e69de29..81aaa1e 100644 > --- a/drivers/rtc/Kconfig @@ -36,7 +35,7 @@ You are missing modifications in the Makefile. > +This driver only supports the RTC feature, and not other chip > +features such as alarms. > +This driver can also be built as a module. If so, the module -> +will be called rtc=E2=80=90max6916. +> +will be called rtc‐max6916. This is badly indented. @@ -47,13 +46,13 @@ This is badly indented. > @@ -0,0 +1,36 @@ > +Changes incorporated after pre-commit review > + -> +1./*created folders=20 +> +1./*created folders > +drivers/rtc/rtc-max6916.c > +drivers/rtc/Kconfig/ > + -> +2./*deleted the port i/o's since it does not add=20 +> +2./*deleted the port i/o's since it does not add > +any significance in overall system design aspect*/ -> +/*=20 +> +/* > +#define ADDRESS_REG 0x70 > +#define DATA_REG 0x71 > +#define ADDRESS_REG_MASK 0xe0 @@ -64,8 +63,8 @@ This is badly indented. > +return inb(DATA_REG); > +}*/ > + -> +3./* Clock burst value is modified from 0X00 to 0X3F and=20 -> +further get_rtc() function is replaced with bcd2bin()=20 +> +3./* Clock burst value is modified from 0X00 to 0X3F and +> +further get_rtc() function is replaced with bcd2bin() > +since the time in Linux is in binary format so the conversion is done*/ > + > + @@ -73,13 +72,12 @@ This is badly indented. > +which is as follows: > +/* starting from year 2000,limit to 100 years from now > +that is subtract the year by 100 */ -> +dt->tm_year =3D dt->tm_year % 100; -> +if(dt->tm_year >=3D 100) -> +dt->tm_year -=3D 100; +> +dt->tm_year = dt->tm_year % 100; +> +if(dt->tm_year >= 100) +> +dt->tm_year -= 100; > + > +if (dt->tm_year < 100 || dt->tm_year > 199) { -> + dev_err(&spi->dev, "Year must be between 2000 and 2099. It's %d.\n",dt= -->tm_year + 1900); +> + dev_err(&spi->dev, "Year must be between 2000 and 2099. It's %d.\n",dt->tm_year + 1900); > + return -EINVAL; > +}*/ > diff --git a/drivers/rtc/rtc-max6916.c b/drivers/rtc/rtc-max6916.c @@ -99,7 +97,7 @@ This is badly indented. > + * published by the Free Software Foundation. > + * > + */ -> +=20 +> + > +#include <linux/init.h> > +#include <linux/module.h> > +#include <linux/device.h> @@ -121,97 +119,94 @@ This is badly indented. > +#define MAX6916_STATUS_REG 0x0C > +#define MAX6916_CLOCK_BURST 0x3F > + -> +static int max6916_read_reg(struct device *dev, unsigned char address,= -=20 +> +static int max6916_read_reg(struct device *dev, unsigned char address, > + unsigned char *data) > +{ -> + struct spi_device *spi =3D to_spi_device(dev); +> + struct spi_device *spi = to_spi_device(dev); > + -> + *data =3D address | 0x80; +> + *data = address | 0x80; > + > + return spi_write_then_read(spi, data, 1, data, 1); > +} > + -> +static int max6916_write_reg(struct device *dev, unsigned char address,= -=20 +> +static int max6916_write_reg(struct device *dev, unsigned char address, > + unsigned char data) > +{ -> + struct spi_device *spi =3D to_spi_device(dev); +> + struct spi_device *spi = to_spi_device(dev); > + unsigned char buf[2]; > + -> + buf[0] =3D address&0x7F; -> + buf[1] =3D data; +> + buf[0] = address&0x7F; +> + buf[1] = data; > + > + return spi_write_then_read(spi, buf, 2, NULL, 0); > +} > + > +static int max6916_read_time(struct device *dev, struct rtc_time *dt) > +{ -> + struct spi_device *spi =3D to_spi_device(dev); +> + struct spi_device *spi = to_spi_device(dev); > + int err; > + unsigned char buf[8]; > + -> + buf[0] =3D MAX6916_CLOCK_BURST | 0x80; -> +=09 -> + err =3D spi_write_then_read(spi, buf, 1, buf, 8); +> + buf[0] = MAX6916_CLOCK_BURST | 0x80; +> + +> + err = spi_write_then_read(spi, buf, 1, buf, 8); > + if (err) > + return err; -> + =09 -> + dt->tm_sec =3D bcd2bin(buf[0]); -> + dt->tm_min =3D bcd2bin(buf[1]); -> + dt->tm_hour =3D bcd2bin(buf[2] & 0x3F); -> + dt->tm_mday =3D bcd2bin(buf[3]); -> + dt->tm_mon =3D bcd2bin(buf[4]) - 1; -> + dt->tm_wday =3D bcd2bin(buf[5]) - 1; -> + dt->tm_year =3D bcd2bin(buf[6]) + 100; +> + +> + dt->tm_sec = bcd2bin(buf[0]); +> + dt->tm_min = bcd2bin(buf[1]); +> + dt->tm_hour = bcd2bin(buf[2] & 0x3F); +> + dt->tm_mday = bcd2bin(buf[3]); +> + dt->tm_mon = bcd2bin(buf[4]) - 1; +> + dt->tm_wday = bcd2bin(buf[5]) - 1; +> + dt->tm_year = bcd2bin(buf[6]) + 100; > + > + return rtc_valid_tm(dt); > +} > + > +static int max6916_set_time(struct device *dev, struct rtc_time *dt) > +{ -> + struct spi_device *spi =3D to_spi_device(dev); +> + struct spi_device *spi = to_spi_device(dev); > + unsigned char buf[9]; > + -> + buf[0] =3D MAX6916_CLOCK_BURST & 0x7F; -> + buf[1] =3D bin2bcd(dt->tm_sec); -> + buf[2] =3D bin2bcd(dt->tm_min); -> + buf[3] =3D (bin2bcd(dt->tm_hour)& 0X3F); -> + buf[4] =3D bin2bcd(dt->tm_mday); -> + buf[5] =3D bin2bcd(dt->tm_mon + 1); -> + buf[6] =3D bin2bcd(dt->tm_wday + 1); +> + buf[0] = MAX6916_CLOCK_BURST & 0x7F; +> + buf[1] = bin2bcd(dt->tm_sec); +> + buf[2] = bin2bcd(dt->tm_min); +> + buf[3] = (bin2bcd(dt->tm_hour)& 0X3F); +> + buf[4] = bin2bcd(dt->tm_mday); +> + buf[5] = bin2bcd(dt->tm_mon + 1); +> + buf[6] = bin2bcd(dt->tm_wday + 1); > + -> + /* starting from year 2000,limit to 100 years=20 +> + /* starting from year 2000,limit to 100 years > + from now that is subtract the year by 100 */ -> + dt->tm_year =3D dt->tm_year % 100; +> + dt->tm_year = dt->tm_year % 100; This is unnecessary -> + if(dt->tm_year >=3D 100) +> + if(dt->tm_year >= 100) You don't need that test if the range is properly enforced. -> + dt->tm_year -=3D 100; -> + =09 +> + dt->tm_year -= 100; +> + > + if (dt->tm_year < 100 || dt->tm_year > 199) { -> + dev_err(&spi->dev,"Year must be between 2000 and 2099. It's %d.\n", dt= -->tm_year + 1900); +> + dev_err(&spi->dev,"Year must be between 2000 and 2099. It's %d.\n", dt->tm_year + 1900); > + return -EINVAL; > + } This test should go at the beginning of the function. -> + =09 -> + buf[7] =3D bin2bcd(dt->tm_year); -> + buf[8] =3D bin2bcd(0x00); -> +=09 +> + +> + buf[7] = bin2bcd(dt->tm_year); +> + buf[8] = bin2bcd(0x00); +> + > + /* write the rtc settings */ > + return spi_write_then_read(spi, buf, 9, NULL, 0); > +} > + -> +static const struct rtc_class_ops max6916_rtc_ops =3D { -> + .read_time =3D max6916_read_time, -> + .set_time =3D max6916_set_time, +> +static const struct rtc_class_ops max6916_rtc_ops = { +> + .read_time = max6916_read_time, +> + .set_time = max6916_set_time, > +}; > + > +static int max6916_probe(struct spi_device *spi) @@ -221,46 +216,32 @@ This test should go at the beginning of the function. > + int res; > + > + /* spi setup with max6916 in mode 3 and bits per word as 8 */ -> + spi->mode =3D SPI_MODE_3; -> + spi->bits_per_word =3D 8; +> + spi->mode = SPI_MODE_3; +> + spi->bits_per_word = 8; > + spi_setup(spi); > + > + /* RTC Settings */ -> + res =3D max6916_read_reg(&spi->dev, MAX6916_SECONDS_REG , &data); -> +=09 +> + res = max6916_read_reg(&spi->dev, MAX6916_SECONDS_REG , &data); +> + > + if (res) > + return res; > + > + /* Disable the write protect of rtc */ > + max6916_read_reg(&spi->dev, MAX6916_CONTROL_REG, &data); -> + data =3D data & ~(1<<7); +> + data = data & ~(1<<7); Please use defines instead of magic values > + max6916_write_reg(&spi->dev, MAX6916_CONTROL_REG, data); > + -> + /*Enable the oscillator,disable the oscillator stop flag, and glitch fi= -lter to reduce current consumption*/ +> + /*Enable the oscillator,disable the oscillator stop flag, and glitch filter to reduce current consumption*/ > + max6916_read_reg(&spi->dev, MAX6916_STATUS_REG, &data); -> + data =3D data & 0x1B; +> + data = data & 0x1B; Also use a define instead of 0x1B. ---=20 +-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com - ---=20 ---=20 -You received this message because you are subscribed to "rtc-linux". -Membership options at http://groups.google.com/group/rtc-linux . -Please read http://groups.google.com/group/rtc-linux/web/checklist -before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. -For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 58fdb8e..4018a77 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "ref\01462526164-6086-1-git-send-email-venkat.prashanth2498@gmail.com\0" "From\0Alexandre Belloni <alexandre.belloni@free-electrons.com>\0" - "Subject\0[rtc-linux] Re: [PATCH] rtc: add support to maxim rtc max6916 v2.0\0" + "Subject\0Re: [PATCH] rtc: add support to maxim rtc max6916 v2.0\0" "Date\0Tue, 10 May 2016 15:20:55 +0200\0" "To\0venkat.prashanth2498@gmail.com\0" "Cc\0a.zummo@towertech.it" @@ -15,10 +15,10 @@ "\n" "On 06/05/2016 at 02:16:04 -0700, venkat.prashanth2498@gmail.com wrote :\n" "> From: venkat-prashanth <venkat.prashanth2498@gmail.com>\n" - ">=20\n" - "> This is a patch to add=20\n" + "> \n" + "> This is a patch to add \n" "> support for maxim rtc MAX6916\n" - ">=20\n" + "> \n" "> Signed-off-by : Venkat Prashanth B U <venkat.prashanth2498@gmail.com>\n" "> ---\n" "\n" @@ -26,13 +26,12 @@ "\n" "> Kconfig | 10 ++++\n" "> changeLOG | 36 ++++++++++++\n" - "> rtc-max6916.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++=\n" - "++++++\n" + "> rtc-max6916.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n" "\n" "You are missing modifications in the Makefile.\n" "\n" "> 3 files changed, 218 insertions(+)\n" - ">=20\n" + "> \n" "> diff --git a/drivers/rtcKconfig b/drivers/rtc/Kconfig\n" "> index e69de29..81aaa1e 100644\n" "> --- a/drivers/rtc/Kconfig\n" @@ -47,7 +46,7 @@ "> +This driver only supports the RTC feature, and not other chip\n" "> +features such as alarms.\n" "> +This driver can also be built as a module. If so, the module\n" - "> +will be called rtc=E2=80=90max6916.\n" + "> +will be called rtc\342\200\220max6916.\n" "\n" "This is badly indented.\n" "\n" @@ -58,13 +57,13 @@ "> @@ -0,0 +1,36 @@\n" "> +Changes incorporated after pre-commit review\n" "> +\n" - "> +1./*created folders=20\n" + "> +1./*created folders \n" "> +drivers/rtc/rtc-max6916.c\n" "> +drivers/rtc/Kconfig/\n" "> +\n" - "> +2./*deleted the port i/o's since it does not add=20\n" + "> +2./*deleted the port i/o's since it does not add \n" "> +any significance in overall system design aspect*/\n" - "> +/*=20\n" + "> +/* \n" "> +#define ADDRESS_REG 0x70\n" "> +#define DATA_REG 0x71\n" "> +#define ADDRESS_REG_MASK 0xe0\n" @@ -75,8 +74,8 @@ "> +return inb(DATA_REG);\n" "> +}*/\n" "> +\n" - "> +3./* Clock burst value is modified from 0X00 to 0X3F and=20\n" - "> +further get_rtc() function is replaced with bcd2bin()=20\n" + "> +3./* Clock burst value is modified from 0X00 to 0X3F and \n" + "> +further get_rtc() function is replaced with bcd2bin() \n" "> +since the time in Linux is in binary format so the conversion is done*/\n" "> +\n" "> +\n" @@ -84,13 +83,12 @@ "> +which is as follows:\n" "> +/* starting from year 2000,limit to 100 years from now\n" "> +that is subtract the year by 100 */\n" - "> +dt->tm_year =3D dt->tm_year % 100;\n" - "> +if(dt->tm_year >=3D 100)\n" - "> +dt->tm_year -=3D 100;\n" + "> +dt->tm_year = dt->tm_year % 100;\n" + "> +if(dt->tm_year >= 100)\n" + "> +dt->tm_year -= 100;\n" "> +\n" "> +if (dt->tm_year < 100 || dt->tm_year > 199) {\n" - "> +\t\tdev_err(&spi->dev, \"Year must be between 2000 and 2099. It's %d.\\n\",dt=\n" - "->tm_year + 1900);\n" + "> +\t\tdev_err(&spi->dev, \"Year must be between 2000 and 2099. It's %d.\\n\",dt->tm_year + 1900);\n" "> +\t\treturn -EINVAL;\n" "> +}*/\n" "> diff --git a/drivers/rtc/rtc-max6916.c b/drivers/rtc/rtc-max6916.c\n" @@ -110,7 +108,7 @@ "> + * published by the Free Software Foundation.\n" "> + *\n" "> + */\n" - "> +=20\n" + "> + \n" "> +#include <linux/init.h>\n" "> +#include <linux/module.h>\n" "> +#include <linux/device.h>\n" @@ -132,97 +130,94 @@ "> +#define MAX6916_STATUS_REG\t 0x0C\n" "> +#define MAX6916_CLOCK_BURST\t0x3F\n" "> +\n" - "> +static int max6916_read_reg(struct device *dev, unsigned char address,=\n" - "=20\n" + "> +static int max6916_read_reg(struct device *dev, unsigned char address, \n" "> +\t\t\t\t unsigned char *data)\n" "> +{\n" - "> +\tstruct spi_device *spi =3D to_spi_device(dev);\n" + "> +\tstruct spi_device *spi = to_spi_device(dev);\n" "> +\n" - "> +\t*data =3D address | 0x80;\n" + "> +\t*data = address | 0x80;\n" "> +\n" "> +\treturn spi_write_then_read(spi, data, 1, data, 1);\n" "> +}\n" "> +\n" - "> +static int max6916_write_reg(struct device *dev, unsigned char address,=\n" - "=20\n" + "> +static int max6916_write_reg(struct device *dev, unsigned char address, \n" "> +\t\t\t\t unsigned char data)\n" "> +{\n" - "> +\tstruct spi_device *spi =3D to_spi_device(dev);\n" + "> +\tstruct spi_device *spi = to_spi_device(dev);\n" "> +\tunsigned char buf[2];\n" "> +\n" - "> +\tbuf[0] =3D address&0x7F;\n" - "> +\tbuf[1] =3D data;\n" + "> +\tbuf[0] = address&0x7F;\n" + "> +\tbuf[1] = data;\n" "> +\n" "> +\treturn spi_write_then_read(spi, buf, 2, NULL, 0);\n" "> +}\n" "> +\n" "> +static int max6916_read_time(struct device *dev, struct rtc_time *dt)\n" "> +{\n" - "> +\tstruct spi_device *spi =3D to_spi_device(dev);\n" + "> +\tstruct spi_device *spi = to_spi_device(dev);\n" "> +\tint err;\n" "> +\tunsigned char buf[8];\n" "> +\n" - "> +\tbuf[0] =3D MAX6916_CLOCK_BURST | 0x80;\n" - "> +=09\n" - "> +\terr =3D spi_write_then_read(spi, buf, 1, buf, 8);\n" + "> +\tbuf[0] = MAX6916_CLOCK_BURST | 0x80;\n" + "> +\t\n" + "> +\terr = spi_write_then_read(spi, buf, 1, buf, 8);\n" "> +\tif (err)\n" "> +\t\treturn err;\n" - "> +\t=09\n" - "> +\tdt->tm_sec =3D bcd2bin(buf[0]);\n" - "> +\tdt->tm_min =3D bcd2bin(buf[1]);\n" - "> +\tdt->tm_hour =3D bcd2bin(buf[2] & 0x3F);\n" - "> +\tdt->tm_mday =3D bcd2bin(buf[3]);\n" - "> +\tdt->tm_mon =3D bcd2bin(buf[4]) - 1;\n" - "> +\tdt->tm_wday =3D bcd2bin(buf[5]) - 1;\n" - "> +\tdt->tm_year =3D bcd2bin(buf[6]) + 100;\n" + "> +\t\t\n" + "> +\tdt->tm_sec = bcd2bin(buf[0]);\n" + "> +\tdt->tm_min = bcd2bin(buf[1]);\n" + "> +\tdt->tm_hour = bcd2bin(buf[2] & 0x3F);\n" + "> +\tdt->tm_mday = bcd2bin(buf[3]);\n" + "> +\tdt->tm_mon = bcd2bin(buf[4]) - 1;\n" + "> +\tdt->tm_wday = bcd2bin(buf[5]) - 1;\n" + "> +\tdt->tm_year = bcd2bin(buf[6]) + 100;\n" "> +\n" "> +\treturn rtc_valid_tm(dt);\n" "> +}\n" "> +\n" "> +static int max6916_set_time(struct device *dev, struct rtc_time *dt)\n" "> +{\n" - "> +\tstruct spi_device *spi =3D to_spi_device(dev);\n" + "> +\tstruct spi_device *spi = to_spi_device(dev);\n" "> +\tunsigned char buf[9];\n" "> +\n" - "> +\tbuf[0] =3D MAX6916_CLOCK_BURST & 0x7F;\n" - "> +\tbuf[1] =3D bin2bcd(dt->tm_sec);\n" - "> +\tbuf[2] =3D bin2bcd(dt->tm_min);\n" - "> +\tbuf[3] =3D (bin2bcd(dt->tm_hour)& 0X3F);\n" - "> +\tbuf[4] =3D bin2bcd(dt->tm_mday);\n" - "> +\tbuf[5] =3D bin2bcd(dt->tm_mon + 1);\n" - "> +\tbuf[6] =3D bin2bcd(dt->tm_wday + 1);\n" + "> +\tbuf[0] = MAX6916_CLOCK_BURST & 0x7F;\n" + "> +\tbuf[1] = bin2bcd(dt->tm_sec);\n" + "> +\tbuf[2] = bin2bcd(dt->tm_min);\n" + "> +\tbuf[3] = (bin2bcd(dt->tm_hour)& 0X3F);\n" + "> +\tbuf[4] = bin2bcd(dt->tm_mday);\n" + "> +\tbuf[5] = bin2bcd(dt->tm_mon + 1);\n" + "> +\tbuf[6] = bin2bcd(dt->tm_wday + 1);\n" "> +\n" - "> +\t/* starting from year 2000,limit to 100 years=20\n" + "> +\t/* starting from year 2000,limit to 100 years \n" "> +\tfrom now that is subtract the year by 100 */\n" - "> +\tdt->tm_year =3D dt->tm_year % 100;\n" + "> +\tdt->tm_year = dt->tm_year % 100;\n" "\n" "This is unnecessary\n" "\n" - "> +\tif(dt->tm_year >=3D 100)\n" + "> +\tif(dt->tm_year >= 100)\n" "\n" "You don't need that test if the range is properly enforced.\n" "\n" - "> +\t\tdt->tm_year -=3D 100;\n" - "> +\t=09\n" + "> +\t\tdt->tm_year -= 100;\n" + "> +\t\t\n" "> +\tif (dt->tm_year < 100 || dt->tm_year > 199) {\n" - "> +\t\tdev_err(&spi->dev,\"Year must be between 2000 and 2099. It's %d.\\n\", dt=\n" - "->tm_year + 1900);\n" + "> +\t\tdev_err(&spi->dev,\"Year must be between 2000 and 2099. It's %d.\\n\", dt->tm_year + 1900);\n" "> +\t\treturn -EINVAL;\n" "> +\t}\n" "\n" "This test should go at the beginning of the function.\n" "\n" - "> + =09\n" - "> +\tbuf[7] =3D bin2bcd(dt->tm_year);\n" - "> +\tbuf[8] =3D bin2bcd(0x00);\n" - "> +=09\n" + "> + \t\n" + "> +\tbuf[7] = bin2bcd(dt->tm_year);\n" + "> +\tbuf[8] = bin2bcd(0x00);\n" + "> +\t\n" "> +\t/* write the rtc settings */\n" "> +\treturn spi_write_then_read(spi, buf, 9, NULL, 0);\n" "> +}\n" "> +\n" - "> +static const struct rtc_class_ops max6916_rtc_ops =3D {\n" - "> +\t.read_time =3D max6916_read_time,\n" - "> +\t.set_time =3D max6916_set_time,\n" + "> +static const struct rtc_class_ops max6916_rtc_ops = {\n" + "> +\t.read_time = max6916_read_time,\n" + "> +\t.set_time = max6916_set_time,\n" "> +};\n" "> +\n" "> +static int max6916_probe(struct spi_device *spi)\n" @@ -232,48 +227,34 @@ "> +\tint res;\n" "> +\n" "> +\t/* spi setup with max6916 in mode 3 and bits per word as 8 */\n" - "> +\tspi->mode =3D SPI_MODE_3;\n" - "> +\tspi->bits_per_word =3D 8;\n" + "> +\tspi->mode = SPI_MODE_3;\n" + "> +\tspi->bits_per_word = 8;\n" "> +\tspi_setup(spi);\n" "> +\n" "> +\t/* RTC Settings */\n" - "> +\tres =3D max6916_read_reg(&spi->dev, MAX6916_SECONDS_REG , &data);\n" - "> +=09\n" + "> +\tres = max6916_read_reg(&spi->dev, MAX6916_SECONDS_REG , &data);\n" + "> +\t\n" "> +\tif (res)\n" "> +\t\treturn res;\n" "> +\n" "> +\t/* Disable the write protect of rtc */\n" "> +\tmax6916_read_reg(&spi->dev, MAX6916_CONTROL_REG, &data);\n" - "> +\tdata =3D data & ~(1<<7);\n" + "> +\tdata = data & ~(1<<7);\n" "\n" "Please use defines instead of magic values\n" "\n" "> +\tmax6916_write_reg(&spi->dev, MAX6916_CONTROL_REG, data);\n" "> +\n" - "> +\t/*Enable the oscillator,disable the oscillator stop flag, and glitch fi=\n" - "lter to reduce current consumption*/\n" + "> +\t/*Enable the oscillator,disable the oscillator stop flag, and glitch filter to reduce current consumption*/\n" "> +\tmax6916_read_reg(&spi->dev, MAX6916_STATUS_REG, &data);\n" - "> +\tdata =3D data & 0x1B;\n" + "> +\tdata = data & 0x1B;\n" "\n" "Also use a define instead of 0x1B.\n" "\n" "\n" - "--=20\n" + "-- \n" "Alexandre Belloni, Free Electrons\n" "Embedded Linux, Kernel and Android engineering\n" - "http://free-electrons.com\n" - "\n" - "--=20\n" - "--=20\n" - "You received this message because you are subscribed to \"rtc-linux\".\n" - "Membership options at http://groups.google.com/group/rtc-linux .\n" - "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" - "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" - For more options, visit https://groups.google.com/d/optout. + http://free-electrons.com -bb825e35e887ffd148c3b1133c3334355ff15a9cdf3bf8e4b5adce2b7d4cd2fa +a8959eca375cc1848bcff86fed137da9020a8f1418add5b5cb30e12ccbea5efe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.