From: Wei Liu <wei.liu2@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: <xen-devel@lists.xenproject.org>, <netdev@vger.kernel.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH net-next 1/4] xen-netback: add control ring boilerplate
Date: Tue, 10 May 2016 14:29:16 +0100 [thread overview]
Message-ID: <20160510132915.GC12241@citrix.com> (raw)
In-Reply-To: <1462447170-1815-2-git-send-email-paul.durrant@citrix.com>
On Thu, May 05, 2016 at 12:19:27PM +0100, Paul Durrant wrote:
[...]
>
> +static int connect_ctrl_ring(struct backend_info *be)
> +{
Please use goto style error handling in this function.
Other than this the code looks good.
Wei.
next prev parent reply other threads:[~2016-05-10 13:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 11:19 [PATCH net-next 0/4] xen-netback: support for control ring Paul Durrant
2016-05-05 11:19 ` [PATCH net-next 1/4] xen-netback: add control ring boilerplate Paul Durrant
2016-05-05 11:19 ` Paul Durrant
2016-05-10 13:29 ` Wei Liu
2016-05-10 13:29 ` Wei Liu [this message]
2016-05-10 13:46 ` Paul Durrant
2016-05-10 13:46 ` Paul Durrant
2016-05-05 11:19 ` [PATCH net-next 2/4] xen-netback: add control protocol implementation Paul Durrant
2016-05-07 19:09 ` David Miller
2016-05-07 19:09 ` David Miller
2016-05-09 8:56 ` Paul Durrant
2016-05-10 13:29 ` Wei Liu
2016-05-10 13:29 ` Wei Liu
2016-05-10 13:46 ` Paul Durrant
2016-05-10 13:46 ` Paul Durrant
2016-05-05 11:19 ` Paul Durrant
2016-05-05 11:19 ` [PATCH net-next 3/4] xen-netback: pass hash value to the frontend Paul Durrant
2016-05-05 11:19 ` Paul Durrant
2016-05-10 13:29 ` Wei Liu
2016-05-10 13:29 ` Wei Liu
2016-05-05 11:19 ` [PATCH net-next 4/4] xen-netback: use hash value from " Paul Durrant
2016-05-05 11:19 ` Paul Durrant
2016-05-10 13:29 ` Wei Liu
2016-05-10 13:29 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510132915.GC12241@citrix.com \
--to=wei.liu2@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.