Re: [PATCH 11/15] vfio: move global vfio_cfg to eal_vfio.c

[Jan Viktorin <viktorin@rehivetech.com>]

On Tue, 10 May 2016 11:56:36 +0000
"Burakov, Anatoly" <anatoly.burakov@intel.com> wrote:

> Hi Jan,
> 
> > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c
> > @@ -39,10 +39,282 @@
> >  #include <rte_log.h>
> >  #include <rte_memory.h>
> >  #include <rte_eal_memconfig.h>
> > +#include <eal_private.h>
> > 
> >  #include "eal_filesystem.h"
> >  #include "eal_vfio.h"  
> 
> I believe the eal_private.h should be local include (in quotes), like in other places.

+1

> 
> > +/**
> > + * Setup vfio_cfg for the device indentified by its address. It
> > +discovers
> > + * the configured I/O MMU groups or sets a new one for the device. If a
> > +new
> > + * groups is assigned, the DMA mapping is performed.
> > + * Returns 0 on success, a negative value on failure and a positive
> > +value in
> > + * case the given device cannot be managed this way.
> > + */  
> 
> I think it would've been good to fix the typo in the comment ("indentified") :)

Ok.

Regards
Jan

> 
> Thanks,
> Anatoly



-- 
  Jan Viktorin                E-mail: Viktorin@RehiveTech.com
  System Architect            Web:    www.RehiveTech.com
  RehiveTech
  Brno, Czech Republic