From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v1 2/2] dmaengine: rename cmd_pause to cmd_suspend
Date: Tue, 10 May 2016 21:41:52 +0530 [thread overview]
Message-ID: <20160510161151.GI2274@localhost> (raw)
In-Reply-To: <1462896023.17131.305.camel@linux.intel.com>
On Tue, May 10, 2016 at 07:00:23PM +0300, Andy Shevchenko wrote:
> On Tue, 2016-05-10 at 21:29 +0530, Vinod Koul wrote:
> > On Wed, May 04, 2016 at 10:29:40PM +0300, Andy Shevchenko wrote:
> > >
> > > Rename cmd_pause to cmd_suspend to be clear that latter capability
> > > reflects
> > > pause AND resume.
> > How does cmd_suspend be any clearer to reflect that channel is paused
> > and
> > not. One can argue this might be related to power management suspend
>
> Okay, I'm open to suggestions. My main point that name should not
> represent only pause or resume, rather both.
I am actually okay with this name, but while getting the capablities, we
should rather tell user if both are supported or not. Perhaps make it a
bit mask?
--
~Vinod
next prev parent reply other threads:[~2016-05-10 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 19:29 [PATCH v1 0/2] dmaengine: urgent fix to prevent regression in UART Andy Shevchenko
2016-05-04 19:29 ` [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC Andy Shevchenko
2016-05-10 15:56 ` Vinod Koul
2016-05-10 16:01 ` Andy Shevchenko
2016-05-10 16:13 ` Vinod Koul
2016-05-04 19:29 ` [PATCH v1 2/2] dmaengine: rename cmd_pause to cmd_suspend Andy Shevchenko
2016-05-10 15:59 ` Vinod Koul
2016-05-10 16:00 ` Andy Shevchenko
2016-05-10 16:11 ` Vinod Koul [this message]
2016-05-06 13:38 ` [PATCH v1 0/2] dmaengine: urgent fix to prevent regression in UART Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510161151.GI2274@localhost \
--to=vinod.koul@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.