From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 10/16] vhost: export vid as the only
 interface to applications
Date: Tue, 10 May 2016 10:29:28 -0700
Message-ID: <20160510172928.GR5641@yliu-dev.sh.intel.com>
References: <1462227927-22853-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1462227927-22853-11-git-send-email-yuanhan.liu@linux.intel.com>
 <CAGSMBPNYVCwAKO5F24SzP96Dt34bBhoTipyu3g5x2fr_FdWbWQ@mail.gmail.com>
 <20160510163927.GO5641@yliu-dev.sh.intel.com>
 <CAGSMBPMy9s2PPvy0VK5W7EZFG_bp4f59345OskohmFfg5YhLfw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, "huawei.xie" <huawei.xie@intel.com>,
 Panu Matilainen <pmatilai@redhat.com>, Tetsuya Mukawa <mukawa@igel.co.jp>,
 Traynor Kevin <kevin.traynor@intel.com>
To: Rich Lane <rich.lane@bigswitch.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 8A306ADEC
 for <dev@dpdk.org>; Tue, 10 May 2016 19:24:46 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CAGSMBPMy9s2PPvy0VK5W7EZFG_bp4f59345OskohmFfg5YhLfw@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 10, 2016 at 10:13:18AM -0700, Rich Lane wrote:
> On Tue, May 10, 2016 at 9:39 AM, Yuanhan Liu <yuanhan.liu@linux.intel.c=
om>
> wrote:
>=20
>     Rich, would you help try by adding following line there and
>     do a test? It would be great if this patch has your Tested-by :)
>=20
>     =A0 =A0 internal->vid =3D vid;
>=20
> =A0
> The problem is new_device has already returned before that point becaus=
e
> find_internal_resource failed.

Oh. right.

> I suggest adding a cookie parameter to=A0rte_vhost_driver_register and =
passing
> the cookie to each of the vhost_ops. The PMD can use pmd_internals for =
the
> cookie and the whole internal_list can go away.

TBH, I don't quite like messing rte_vhost_driver_register here.

Maybe I could switch back to the old way to find_internal_resource by
ifname. In such case, I need introduce an API to expose that field
from vhost lib.

> ps. Could you push git branches somewhere for these larger vhost patch =
series?
> That would make it a lot easier to test than getting patches individual=
ly from
> patchwork.

Yes, indeeded. And I have a tree on dpdk.org, but that is mainly for
holding patches for the mainline. I'm thinking I may could add a new
branch there, say staging, just for testing. Thomas, will it work for
you? Or, should I push it to github?

	--yliu