All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Robert Foss <robert.foss@collabora.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v4 4/5] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.
Date: Tue, 10 May 2016 20:58:22 +0300	[thread overview]
Message-ID: <20160510175822.GX4329@intel.com> (raw)
In-Reply-To: <20160510171950.GV4329@intel.com>

On Tue, May 10, 2016 at 08:19:50PM +0300, Ville Syrjälä wrote:
> On Tue, May 10, 2016 at 08:03:47PM +0300, Marius Vlad wrote:
> > Robert Foss improved test/kms_vblank and in the same time extended it on
> > all outputs and all pipes. The following seems to happen on pipe B (on
> > pipe A the test always works):
> > 
> > [46795.932490] [drm:drm_wait_vblank] returning 66 to client
> > [46795.932509] [drm:drm_ioctl] pid=17715, dev=0xe200, auth=1, DRM_IOCTL_WAIT_VBLANK
> > [46795.932512] [drm:drm_queue_vblank_event] event on vblank count 132, current 66, crtc 1

That 132 was already confusing me, so I started to look the full log. I
then noticed the following pattern:
[46795.882483] [drm:drm_queue_vblank_event] event on vblank count 129, current 63, crtc 1
[46795.899180] [drm:drm_queue_vblank_event] event on vblank count 130, current 64, crtc 1
[46795.915843] [drm:drm_queue_vblank_event] event on vblank count 131, current 65, crtc 1
[46795.932512] [drm:drm_queue_vblank_event] event on vblank count 132, current 66, crtc 1

So the target vblank count was incrementing in lockstep with the current
counter value, which then told me these are relative waits instead of
absolute as they should have been. It's a bug in the pipe_id_to_vbl_flag().
I replied to the relevant mail already.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-05-10 17:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 15:54 [PATCH i-g-t v4 0/5] kms_flip_event_leak and kms_vblank fixes for VC4 robert.foss
2016-04-26 15:54 ` [PATCH i-g-t v4 1/5] lib/igt_kms: Add support for up to 10 planes robert.foss
2016-04-26 15:54 ` [PATCH i-g-t v4 2/5] lib/igt_kms: Fix plane counting in igt_display_init robert.foss
2016-04-26 15:54 ` [PATCH i-g-t v4 3/5] lib/igt_kms: Switch to verbose assert robert.foss
2016-04-26 15:54 ` [PATCH i-g-t v4 4/5] kms_vblank: Switch from using crtc0 statically to explicitly setting mode robert.foss
2016-05-09 15:38   ` Marius Vlad
2016-05-09 20:31     ` Robert Foss
     [not found]       ` <5730F578.8000909@collabora.com>
2016-05-10 17:03         ` Marius Vlad
2016-05-10 17:19           ` Ville Syrjälä
2016-05-10 17:36             ` Chris Wilson
2016-05-10 17:58             ` Ville Syrjälä [this message]
2016-04-26 15:54 ` [PATCH i-g-t v4 5/5] lib/igt_kms: Added pipe_id_to_vbl_flag() to igt_kms robert.foss
2016-05-10  7:44   ` Daniel Vetter
2016-05-11 13:45     ` Robert Foss
2016-05-11 15:31       ` Robert Foss
2016-05-10 17:54   ` Ville Syrjälä
2016-05-11 13:49     ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510175822.GX4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=robert.foss@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.