All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] Resuming nanosleep & Co. after ignored signals
Date: Wed, 11 May 2016 08:05:45 +0200	[thread overview]
Message-ID: <20160511060545.GH13285@hermes.click-hack.org> (raw)
In-Reply-To: <57320A7D.1060105@siemens.com>

On Tue, May 10, 2016 at 06:21:17PM +0200, Jan Kiszka wrote:
> On 2016-05-10 18:08, Gilles Chanteperdrix wrote:
> > On Tue, May 10, 2016 at 05:57:05PM +0200, Jan Kiszka wrote:
> >> Hi,
> >>
> >> originally, this effect was only reported for debugged applications, but
> >> I think it affects more:
> >>
> >> clock_nanosleep (as well as nanosleep and sleep) should return -EINTR if
> >> they were interrupted by signal while sleeping. OK. But what if that
> >> signal was SIGSTOP, maybe even related to ptrace? Right now the function
> >> just bails out, and applications behave differently from native Linux.
> >> There we resume the sleep transparently if the signal is not delivered
> >> to some handler (or actually terminates the process).
> >>
> >> How could we model this properly with Xenomai? And could there be more
> >> services affected than clock_nanosleep?
> > 
> > I was going to say, this is unspecified by POSIX, but actually it
> > is:
> > http://pubs.opengroup.org/onlinepubs/9699919799/functions/clock_nanosleep.html
> > 
> > The relevant sentence is:
> > "the clock_nanosleep() function shall cause the current thread to be
> > suspended from execution until either the time interval specified by
> > the rqtp argument has elapsed, or a signal is delivered to the
> > calling thread and its action is to invoke a signal-catching
> > function"
> > 
> > Clearly, the action of SIGSTOP is not "a signal-catching function",
> > and the sleep should not appear to have been interrupted.
> > 
> > Just saying, I have no idea whatsoever on how to get this working.
> 
> It's at least not trivial: The kernel has per-thread restart blocks
> where it pushes the timer state of an interrupted relative
> clock_nanosleep so that the restarted syscall will not restart the timer
> at 0.
> 
> And then we still need to differentiate between those two signal types
> (delivered to handler vs. internally processed).

Since we will return from the xenomai syscall in secondary mode, we
could conceivably go through the plain Linux syscall epilogue with
the restart block, using a specific restart block which piggy backs
into xenomai kernel. I wonder if xenomai syscall returning in
secondary mode do not go through the plain Linux syscall epilogue
already, actually.

-- 
					    Gilles.
https://click-hack.org


  reply	other threads:[~2016-05-11  6:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 15:57 [Xenomai] Resuming nanosleep & Co. after ignored signals Jan Kiszka
2016-05-10 16:08 ` Gilles Chanteperdrix
2016-05-10 16:21   ` Jan Kiszka
2016-05-11  6:05     ` Gilles Chanteperdrix [this message]
2016-05-11  7:17       ` Philippe Gerum
2016-05-11  7:25         ` Jan Kiszka
2016-05-12 20:07           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160511060545.GH13285@hermes.click-hack.org \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.