From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0SdM-0003sm-T2 for qemu-devel@nongnu.org; Wed, 11 May 2016 07:49:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0SdK-0002pb-Ba for qemu-devel@nongnu.org; Wed, 11 May 2016 07:48:55 -0400 Date: Wed, 11 May 2016 12:48:41 +0100 From: "Richard W.M. Jones" Message-ID: <20160511114841.GE1683@redhat.com> References: <1462848659-28659-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462848659-28659-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, Kevin Wolf , Max Reitz , Jeff Cody , Markus Armbruster , Eric Blake , qemu-block@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, John Snow , berrange@redhat.com, den@openvz.org While I remember there is another concern that doesn't seem to be addressed in this patch series. What happens when a guest is paused? I think exclusive locks should be converted to shared locks in that case, since (only while the guest is paused) it _is_ safe to fish around inside the guest's state. Of course the lock must be restored before the guest resumes. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW