From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH RESEND 1/2] regulator: Add support for parsing operation mode Date: Wed, 11 May 2016 15:46:32 +0100 Message-ID: <20160511144632.GH6261@sirena.org.uk> References: <1462959090-2877-1-git-send-email-henryc.chen@mediatek.com> <1462959090-2877-2-git-send-email-henryc.chen@mediatek.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xQmOcGOVkeO43v2v" Return-path: Content-Disposition: inline In-Reply-To: <1462959090-2877-2-git-send-email-henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Henry Chen Cc: Rob Herring , Liam Girdwood , Matthias Brugger , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Stephen Boyd , Bjorn Andersson , Laxman Dewangan , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org --xQmOcGOVkeO43v2v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 11, 2016 at 05:31:29PM +0800, Henry Chen wrote: > +- regulator-allow-change-mode: allow the regulator mode to be configured > +- regulator-supported-modes: Regulators can run in a variety of different operating > + modes depending on output load. This allows further system power savings by > + selecting the best (and most efficient) regulator mode for a desired load. > + The definition for each of these operation is defined at > + include/linux/regulator/consumer.h It really isn't OK for a DT binding to be documented by referencing Linux kernel internals. > + 0: FAST. > + 1: NORMAL. > + 2: IDLE. > + 3: STANDBY. The problem with these is that they don't really mean anything outside of a specific regulator. This makes it very hard to make them at all interoperable, and is also incompatible with the way we're currently handling the modes elsewhere in the bindings. If we're going to make an ABI of this we need to have something with abstraction in it but it's hard to see how to abstract modes since they're so implementation specific, even if the mechanisms are similar the different load ranges that regulators support mean that what's a very taxing load for one regulator may be nothing to another. --xQmOcGOVkeO43v2v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXM0XGAAoJECTWi3JdVIfQXaEH/ir8TUe8a3SqSLLwGwueng6o MdcL0Ae3iEaFhdT59kKRHgB70ORdEBRFQnt8I4uG3acHyuupy+JTyuP/7V3RXQJ5 unGcqP30uXuhAgWMOCk0c3j/FAzH8Cd3TEymKn6qxQLRDLuRfdOf3DFes17WV0Qh t9DhOYGMSZeSRbUVN3zwlw3kFn612lqkuOegb5nrGes8Emp1db2g2e3hLz1vcDMR hAZ5PGpQlR0rW3EhHH/p35RUF5H2HpBs2EQLDWElSE9o5TepDyU2zgz8Ur/xrDEk 5GYQL5emoS9lQIQ/J39yT/ci5R63Rcw20YXNRDbmqspafF5aAadaL9c18sM1Q6c= =JSAM -----END PGP SIGNATURE----- --xQmOcGOVkeO43v2v-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752404AbcEKOrE (ORCPT ); Wed, 11 May 2016 10:47:04 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44186 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbcEKOrD (ORCPT ); Wed, 11 May 2016 10:47:03 -0400 Date: Wed, 11 May 2016 15:46:32 +0100 From: Mark Brown To: Henry Chen Cc: Rob Herring , Liam Girdwood , Matthias Brugger , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Stephen Boyd , Bjorn Andersson , Laxman Dewangan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Message-ID: <20160511144632.GH6261@sirena.org.uk> References: <1462959090-2877-1-git-send-email-henryc.chen@mediatek.com> <1462959090-2877-2-git-send-email-henryc.chen@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xQmOcGOVkeO43v2v" Content-Disposition: inline In-Reply-To: <1462959090-2877-2-git-send-email-henryc.chen@mediatek.com> X-Cookie: When in doubt, follow your heart. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH RESEND 1/2] regulator: Add support for parsing operation mode X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xQmOcGOVkeO43v2v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 11, 2016 at 05:31:29PM +0800, Henry Chen wrote: > +- regulator-allow-change-mode: allow the regulator mode to be configured > +- regulator-supported-modes: Regulators can run in a variety of different operating > + modes depending on output load. This allows further system power savings by > + selecting the best (and most efficient) regulator mode for a desired load. > + The definition for each of these operation is defined at > + include/linux/regulator/consumer.h It really isn't OK for a DT binding to be documented by referencing Linux kernel internals. > + 0: FAST. > + 1: NORMAL. > + 2: IDLE. > + 3: STANDBY. The problem with these is that they don't really mean anything outside of a specific regulator. This makes it very hard to make them at all interoperable, and is also incompatible with the way we're currently handling the modes elsewhere in the bindings. If we're going to make an ABI of this we need to have something with abstraction in it but it's hard to see how to abstract modes since they're so implementation specific, even if the mechanisms are similar the different load ranges that regulators support mean that what's a very taxing load for one regulator may be nothing to another. --xQmOcGOVkeO43v2v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXM0XGAAoJECTWi3JdVIfQXaEH/ir8TUe8a3SqSLLwGwueng6o MdcL0Ae3iEaFhdT59kKRHgB70ORdEBRFQnt8I4uG3acHyuupy+JTyuP/7V3RXQJ5 unGcqP30uXuhAgWMOCk0c3j/FAzH8Cd3TEymKn6qxQLRDLuRfdOf3DFes17WV0Qh t9DhOYGMSZeSRbUVN3zwlw3kFn612lqkuOegb5nrGes8Emp1db2g2e3hLz1vcDMR hAZ5PGpQlR0rW3EhHH/p35RUF5H2HpBs2EQLDWElSE9o5TepDyU2zgz8Ur/xrDEk 5GYQL5emoS9lQIQ/J39yT/ci5R63Rcw20YXNRDbmqspafF5aAadaL9c18sM1Q6c= =JSAM -----END PGP SIGNATURE----- --xQmOcGOVkeO43v2v--