From: Mark Brown <broonie@kernel.org>
To: Henry Chen <henryc.chen@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH RESEND 2/2] regulator: mt6397: Add buck change mode regulator interface for mt6397
Date: Wed, 11 May 2016 15:50:46 +0100 [thread overview]
Message-ID: <20160511145046.GI6261@sirena.org.uk> (raw)
In-Reply-To: <1462959090-2877-3-git-send-email-henryc.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On Wed, May 11, 2016 at 05:31:30PM +0800, Henry Chen wrote:
> +The possible values for "regulator-supported-modes" are:
> + 0: PWM mode, mapping to regulator fast mode, allow the
> + converter to remain in the PWM mode regardless of the load current, so
> + that the noise spectrum of the converter can be minimized for certain
> + highly-noise-sensitive handset applications.
> + 1: Auto mode, mapping to regulator normal mode, mode switch by current
> + loading. At light load currents, the converter automatically enters
> + PFM mode to save power and improve light load efficiency. At heavy
> + load currents, the converter automatically enters PWM mode to minimiz
> + the noise spectrum of the converter.
The details of how this maps onto Linux shouldn't be in the bindings.
> + regulator-allow-change-mode;
> + regulator-supported-modes = <0 1>;
These are problematic too as covered in my other mail.
> -static struct regulator_ops mt6397_volt_range_ops = {
> +static const struct regulator_ops mt6397_volt_range_ops = {
The constification is fine but an unrelated change. Otherwise this
looks fine from a code point of view, let's get that merged separately.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-11 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 9:31 Add support for regulator operation mode of mt6397 Henry Chen
2016-05-11 9:31 ` Henry Chen
2016-05-11 9:31 ` Henry Chen
2016-05-11 9:31 ` [PATCH RESEND 1/2] regulator: Add support for parsing operation mode Henry Chen
2016-05-11 9:31 ` Henry Chen
2016-05-11 9:31 ` Henry Chen
[not found] ` <1462959090-2877-2-git-send-email-henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-05-11 14:46 ` Mark Brown
2016-05-11 14:46 ` Mark Brown
[not found] ` <1462959090-2877-1-git-send-email-henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-05-11 9:31 ` [PATCH RESEND 2/2] regulator: mt6397: Add buck change mode regulator interface for mt6397 Henry Chen
2016-05-11 9:31 ` Henry Chen
2016-05-11 9:31 ` Henry Chen
2016-05-11 14:50 ` Mark Brown [this message]
[not found] ` <20160511145046.GI6261-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-13 8:04 ` Henry Chen
2016-05-13 8:04 ` Henry Chen
2016-05-13 8:04 ` Henry Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511145046.GI6261@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=henryc.chen@mediatek.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.