From: Olof Johansson <olof@lixom.net>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: rdunlap@infradead.org, olofj@chromium.org,
alan@lxorguk.ukuu.org.uk, cernekee@chromium.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] platform/chrome: cros_ec_dev - Fix security issue
Date: Wed, 11 May 2016 10:58:13 -0700 [thread overview]
Message-ID: <20160511175813.GB21847@localhost> (raw)
In-Reply-To: <1457457232-2926-1-git-send-email-gwendal@chromium.org>
On Tue, Mar 08, 2016 at 09:13:52AM -0800, Gwendal Grignou wrote:
> Prevent memory scribble by checking that ioctl buffer size parameters
> are sane.
> Without this check, on 32 bits system, if .insize = 0xffffffff - 20 and
> .outsize the amount to scribble, we would overflow, allocate a small
> amounts and be able to write outside of the malloc'ed area.
> Adding a hard limit allows argument checking of the ioctl. With the
> current EC, it is expected .insize and .outsize to be at around 512 bytes
> or less.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Applied now.
-Olof
prev parent reply other threads:[~2016-05-11 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 20:33 Security hole in cros_ec_dev.c on 32bit chrome hosts Alan Cox
2016-03-03 5:58 ` [PATCH] platform/chrome: cros_ec_dev - Fix security issue Gwendal Grignou
2016-03-03 18:35 ` Randy Dunlap
2016-03-03 19:00 ` [PATCH v2] " Gwendal Grignou
2016-03-06 20:11 ` Olof Johansson
2016-03-08 17:02 ` Gwendal Grignou
2016-03-08 17:13 ` [PATCH v3] " Gwendal Grignou
2016-05-11 17:58 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511175813.GB21847@localhost \
--to=olof@lixom.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cernekee@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.