From: Olof Johansson <olof@lixom.net>
To: Clinton Sprain <clintonsprain@gmail.com>
Cc: gwendal@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_lightbar - use name instead of ID to hide lightbar attributes
Date: Wed, 11 May 2016 11:04:50 -0700 [thread overview]
Message-ID: <20160511180450.GD21847@localhost> (raw)
In-Reply-To: <1457498184-4170-1-git-send-email-clintonsprain@gmail.com>
On Tue, Mar 08, 2016 at 10:36:24PM -0600, Clinton Sprain wrote:
> Lightbar attributes are hidden if the ID of the device is not 0
> (the assumption being that 0 = cros_ec = might have a lightbar,
> 1 = cros_pd = hide); however, sometimes these devices get IDs 1
> and 2 (or something else) instead of IDs 0 and 1. This prevents
> the lightbar attributes from appearing when they should.
>
> Proposed change is to instead check whether the name assigned to
> the device is CROS_EC_DEV_NAME (true for cros_ec, false for cros_pd).
>
> Signed-off-by: Clinton Sprain <clintonsprain@gmail.com>
Hm. I wonder why we need to check at all, given that the lightbar version check
is just going to fail later anyway.
Either way, applied with some manual fixups due to surrounding changes.
Apologies for the long delay here.
-Olof
prev parent reply other threads:[~2016-05-11 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 4:36 [PATCH] platform/chrome: cros_ec_lightbar - use name instead of ID to hide lightbar attributes Clinton Sprain
2016-05-11 18:04 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511180450.GD21847@localhost \
--to=olof@lixom.net \
--cc=clintonsprain@gmail.com \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.