Re: [PATCH V1 for-next 1/2] IB/core: Report LSO capabilities when querying device

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]

On Wed, May 11, 2016 at 11:36:08AM -0600, Jason Gunthorpe wrote:
> On Wed, May 11, 2016 at 07:31:34AM +0300, Leon Romanovsky wrote:
> > On Tue, May 10, 2016 at 08:04:29PM -0600, Jason Gunthorpe wrote:
> > > Look at the patches. The LSO patch is so bad Sean and Steve couldn't
> > > even figure out what the heck the HW feature does. I know what it
> > > does, but I can't tell you the fine details of the actual required
> > > hardware behavior.
> > 
> > These people are very busy and you can't expect from them to know
> > everything, If someone doesn't know/understand, he will ask, exactly
> > as they, you and me are doing all the time.
> > 
> > Just to remind you, that YOUR's patch [1] didn't meet YOUR own quality
> > criteria and can be called bad one, just because very respectful people
> > asked their questions which very expected to be answered in the patch
> > itself, but they don't [2].
> 
> Oh come on, can you please get serious about this? Stubbornly taking a
> baseless and totally obstinate position is not working with the
> community.
> 
> A security patch, which is deliberately a little obtuse to avoid
> telling the world how to write an exploit, is not at all the same as
> describing a complex new uAPI feature that is expected to be
> implementable by other parties.
> 
> I can't believe you'd even try to use that as an excuse.

It is not an excuse and never supposed to be.

My position is very concrete on this topic: post code on ML, start
discussion, adjust the code and merge it.

It works for all other code posted on various linux kernel ML and
I don't see why it can't work for RDMA too.

And again, there is openness and readiness of all participants in this
ML to answer feedback and post adjusted code.

> 
> Jason

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]