From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbcEKUeL (ORCPT ); Wed, 11 May 2016 16:34:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:60458 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbcEKUeJ (ORCPT ); Wed, 11 May 2016 16:34:09 -0400 Date: Wed, 11 May 2016 22:34:04 +0200 From: Borislav Petkov To: Dave Hansen Cc: Yu-cheng Yu , linux-kernel@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Andy Lutomirski , Sai Praneeth Prakhya , "Ravi V. Shankar" , Fenghua Yu Subject: Re: [PATCH v7 00/13] x86/xsaves: Fix XSAVES issues Message-ID: <20160511203404.GR2180@pd.tnic> References: <20160511200436.GP2180@pd.tnic> <5733928B.7030909@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5733928B.7030909@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 01:14:03PM -0700, Dave Hansen wrote: > But, seriously, he's churning through, responding to feedback and > improving the patches quickly. I only wish most patch authors did this. > And, despite breaking it up into 13 pieces, there is *NOT* a lot of > code here. I don't think we review only code, do we?! And as I pointed out a couple of times, those patches weren't clean. Hell, they even didn't build on tip/master. So even the "responding to feedback" failed. So what is your point again? > There's no sane reason to wait a week between iterations. I don't think so - review is review and takes time. You should know this even better than me. > Just speak up if you want off the cc. Sure. I thought you'd never ask. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --