From: Stephen Boyd <sboyd@codeaurora.org>
To: Pramod Gurav <pramod.gurav@linaro.org>
Cc: andy.gross@linaro.org, gregkh@linuxfoundation.org,
davidb@codeaurora.org, jslaby@suse.com,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: msm: Remove duplicate handling of clocks
Date: Wed, 11 May 2016 17:18:37 -0700 [thread overview]
Message-ID: <20160512001837.GJ3492@codeaurora.org> (raw)
In-Reply-To: <1462957229-17567-1-git-send-email-pramod.gurav@linaro.org>
On 05/11, Pramod Gurav wrote:
> msm_serial driver provides a .pm callback to the serial core to enable
> and disable clock resource in suspend/resume path. This function is
> also called before msm_startup. msm_startup also enables the clocks which
> is not needed. Hence remove the duplcate clock operation from msm_startup
> and msm_shutdown. Same is done in console setup to get rid of duplicate
> clock operation.
I had to check and I see that for the console case we call the
.pm callback and don't turn it off until suspend/resume paths
(would be nice to add suspend/resume to this driver too). I
guess that's what you meant by this last sentence?
>
> Tested on DB410C console.
>
> Signed-off-by: Pramod Gurav <pramod.gurav@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-05-12 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 9:00 [PATCH] tty: serial: msm: Remove duplicate handling of clocks Pramod Gurav
2016-05-12 0:18 ` Stephen Boyd [this message]
2016-05-12 4:38 ` Pramod Gurav
2016-05-16 8:31 ` Pramod Gurav
2016-05-25 23:07 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512001837.GJ3492@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=davidb@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pramod.gurav@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.