Re: [Qemu-devel] [PATCH] pci: fix requester id to be the one on root bus

[Peter Xu <peterx@redhat.com>]

On Wed, May 11, 2016 at 04:53:54PM +0300, Michael S. Tsirkin wrote:
> On Wed, May 11, 2016 at 02:40:31PM +0800, Peter Xu wrote:
> > When there are devices under PCI bridge (or bridges), PCI requester ID
> > should be the one that hooked on the root PCI bus, not the PCI device
> > itself.
> > 
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> 
> I think this is only correct for pci bridges, and wrong for pci express bridges.
> 
> How exactly do you test this?

I was using Radim's test case:

bin=x86_64-softmmu/qemu-system-x86_64
$bin -machine q35,iommu=on,intremap=on,kernel-irqchip=split \
     -smp cpus=2 -m 1024 -enable-kvm \
     -device i82801b11-bridge,id=pci.1,bus=pcie.0,addr=0x1e \
     -device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \
     -netdev user,id=user.0,hostfwd=tcp::5555-:22 \
     -device e1000,netdev=user.0,bus=pci.2,addr=0x1 \
     -drive file=/var/lib/libvirt/images/vm1.qcow2,format=qcow2,if=none,id=drive-virtio-disk0 \
     -device virtio-blk-pci,scsi=off,bus=pci.2,addr=0x3,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1

This does not boot on v6 series, but can boot with the patch
mentioned.

Do you know where I can find any document on related topics?

Thanks in advance.

-- peterx