diff for duplicates of <20160512061636.GA4200@dhcp22.suse.cz> diff --git a/a/1.txt b/N1/1.txt index e9e26c1..3c218d3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,3 +3,43 @@ you fold it into the original mm-compaction-simplify-__alloc_pages_direct_compact-feedback-interface.patch patch? --- +>From 434bc8b6f3787724327499998c4fe651e8ce5d68 Mon Sep 17 00:00:00 2001 +From: Michal Hocko <mhocko@suse.com> +Date: Thu, 12 May 2016 08:10:33 +0200 +Subject: [PATCH] mmotm: + mm-compaction-simplify-__alloc_pages_direct_compact-feedback-interface-fix + +Arnd has reported the following compilation warning: +mm/page_alloc.c: In function '__alloc_pages_nodemask': +mm/page_alloc.c:3651:6: error: 'compact_result' may be used uninitialized in this function [-Werror=maybe-uninitialized] + +This should be a false positive TRANSPARENT_HUGEPAGE depends on COMPACTION +so is_thp_gfp_mask shouldn't be true. GFP_TRANSHUGE is a bit tricky +and somebody might be using this accidently. Make sure that compact_result +is defined also for !CONFIG_COMPACT and set it to COMPACT_SKIPPED because +the compaction was really withdrawn. + +Reported-by: Arnd Bergmann <arnd@arndb.de> +Signed-off-by: Michal Hocko <mhocko@suse.com> +--- + mm/page_alloc.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/mm/page_alloc.c b/mm/page_alloc.c +index 4950d01ff935..0d9008042efa 100644 +--- a/mm/page_alloc.c ++++ b/mm/page_alloc.c +@@ -3300,6 +3300,7 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, + unsigned int alloc_flags, const struct alloc_context *ac, + enum migrate_mode mode, enum compact_result *compact_result) + { ++ *compact_result = COMPACT_SKIPPED; + return NULL; + } + +-- +2.8.1 + +-- +Michal Hocko +SUSE Labs diff --git a/a/content_digest b/N1/content_digest index b283e00..ca2364d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -18,6 +18,46 @@ "you fold it into the original\n" "mm-compaction-simplify-__alloc_pages_direct_compact-feedback-interface.patch\n" "patch?\n" - --- + "---\n" + ">From 434bc8b6f3787724327499998c4fe651e8ce5d68 Mon Sep 17 00:00:00 2001\n" + "From: Michal Hocko <mhocko@suse.com>\n" + "Date: Thu, 12 May 2016 08:10:33 +0200\n" + "Subject: [PATCH] mmotm:\n" + " mm-compaction-simplify-__alloc_pages_direct_compact-feedback-interface-fix\n" + "\n" + "Arnd has reported the following compilation warning:\n" + "mm/page_alloc.c: In function '__alloc_pages_nodemask':\n" + "mm/page_alloc.c:3651:6: error: 'compact_result' may be used uninitialized in this function [-Werror=maybe-uninitialized]\n" + "\n" + "This should be a false positive TRANSPARENT_HUGEPAGE depends on COMPACTION\n" + "so is_thp_gfp_mask shouldn't be true. GFP_TRANSHUGE is a bit tricky\n" + "and somebody might be using this accidently. Make sure that compact_result\n" + "is defined also for !CONFIG_COMPACT and set it to COMPACT_SKIPPED because\n" + "the compaction was really withdrawn.\n" + "\n" + "Reported-by: Arnd Bergmann <arnd@arndb.de>\n" + "Signed-off-by: Michal Hocko <mhocko@suse.com>\n" + "---\n" + " mm/page_alloc.c | 1 +\n" + " 1 file changed, 1 insertion(+)\n" + "\n" + "diff --git a/mm/page_alloc.c b/mm/page_alloc.c\n" + "index 4950d01ff935..0d9008042efa 100644\n" + "--- a/mm/page_alloc.c\n" + "+++ b/mm/page_alloc.c\n" + "@@ -3300,6 +3300,7 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order,\n" + " \t\tunsigned int alloc_flags, const struct alloc_context *ac,\n" + " \t\tenum migrate_mode mode, enum compact_result *compact_result)\n" + " {\n" + "+\t*compact_result = COMPACT_SKIPPED;\n" + " \treturn NULL;\n" + " }\n" + " \n" + "-- \n" + "2.8.1\n" + "\n" + "-- \n" + "Michal Hocko\n" + SUSE Labs -d6a508cb6dc2803c60a056c1f0086fef673e8bb6a820fa9fb6a3ffdb608f139c +77ff86f6639d4e189eecb96262eb9464a180c42385c6d75480fb50a7dec892f0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.