From: Peter Zijlstra <peterz@infradead.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: linux-perf-users@vger.kernel.org,
Vince Weaver <vincent.weaver@maine.edu>,
linux-kernel@vger.kernel.org, acme@redhat.com,
linux-snps-arc@lists.infradead.org, mingo@kernel.org
Subject: Re: [RFC 2/2] perf/core: change errno for sampling event not supported in hardware
Date: Thu, 12 May 2016 08:42:01 +0200 [thread overview]
Message-ID: <20160512064201.GL3192@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <5734229B.90706@synopsys.com>
On Thu, May 12, 2016 at 11:58:43AM +0530, Vineet Gupta wrote:
> On Thursday 12 May 2016 01:06 AM, Peter Zijlstra wrote:
> > On Mon, May 09, 2016 at 10:53:43PM +0530, Vineet Gupta wrote:
> >
> >> > Right thats what I feared. But hold on, I don't think we need to change the ABI to
> >> > achieve what we want. Gosh why did I even take that path.
> >> >
> >> > Currently the errno switch case in perf_evsel__open_strerror() in doesn't handle
> >> > ENOTSUPP. So how about we add that - augmented with the same sample_period !0
> >> > check to barf for lack of sampling support.
> >> >
> >> > Do you see anything wrong with that ?
> >
> > Should work I think.
>
> Tried that and doesn't even compile. Reconfirms what Vince said, ENOTSUPP is not
> exposed to userspace (being in include/linux and not include/uapi/linux)
Durr, so what does userspace see?
WARNING: multiple messages have this Message-ID (diff)
From: peterz@infradead.org (Peter Zijlstra)
To: linux-snps-arc@lists.infradead.org
Subject: [RFC 2/2] perf/core: change errno for sampling event not supported in hardware
Date: Thu, 12 May 2016 08:42:01 +0200 [thread overview]
Message-ID: <20160512064201.GL3192@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <5734229B.90706@synopsys.com>
On Thu, May 12, 2016@11:58:43AM +0530, Vineet Gupta wrote:
> On Thursday 12 May 2016 01:06 AM, Peter Zijlstra wrote:
> > On Mon, May 09, 2016@10:53:43PM +0530, Vineet Gupta wrote:
> >
> >> > Right thats what I feared. But hold on, I don't think we need to change the ABI to
> >> > achieve what we want. Gosh why did I even take that path.
> >> >
> >> > Currently the errno switch case in perf_evsel__open_strerror() in doesn't handle
> >> > ENOTSUPP. So how about we add that - augmented with the same sample_period !0
> >> > check to barf for lack of sampling support.
> >> >
> >> > Do you see anything wrong with that ?
> >
> > Should work I think.
>
> Tried that and doesn't even compile. Reconfirms what Vince said, ENOTSUPP is not
> exposed to userspace (being in include/linux and not include/uapi/linux)
Durr, so what does userspace see?
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: acme@redhat.com, Vince Weaver <vincent.weaver@maine.edu>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-snps-arc@lists.infradead.org, mingo@kernel.org
Subject: Re: [RFC 2/2] perf/core: change errno for sampling event not supported in hardware
Date: Thu, 12 May 2016 08:42:01 +0200 [thread overview]
Message-ID: <20160512064201.GL3192@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <5734229B.90706@synopsys.com>
On Thu, May 12, 2016 at 11:58:43AM +0530, Vineet Gupta wrote:
> On Thursday 12 May 2016 01:06 AM, Peter Zijlstra wrote:
> > On Mon, May 09, 2016 at 10:53:43PM +0530, Vineet Gupta wrote:
> >
> >> > Right thats what I feared. But hold on, I don't think we need to change the ABI to
> >> > achieve what we want. Gosh why did I even take that path.
> >> >
> >> > Currently the errno switch case in perf_evsel__open_strerror() in doesn't handle
> >> > ENOTSUPP. So how about we add that - augmented with the same sample_period !0
> >> > check to barf for lack of sampling support.
> >> >
> >> > Do you see anything wrong with that ?
> >
> > Should work I think.
>
> Tried that and doesn't even compile. Reconfirms what Vince said, ENOTSUPP is not
> exposed to userspace (being in include/linux and not include/uapi/linux)
Durr, so what does userspace see?
next prev parent reply other threads:[~2016-05-12 6:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 9:37 [RFC 0/2] report perf sampling failing due to PMU lacking overflow intr support Vineet Gupta
2016-05-09 9:37 ` Vineet Gupta
2016-05-09 9:37 ` Vineet Gupta
2016-05-09 9:37 ` [RFC 1/2] tools/perf: Handle EOPNOTSUPP for sampling events Vineet Gupta
2016-05-09 9:37 ` Vineet Gupta
2016-05-09 9:37 ` Vineet Gupta
2016-06-03 10:52 ` [tip:perf/core] tools/perf: Handle -EOPNOTSUPP " tip-bot for Vineet Gupta
2016-06-03 10:52 ` tip-bot for Vineet Gupta
2016-05-09 9:37 ` [RFC 2/2] perf/core: change errno for sampling event not supported in hardware Vineet Gupta
2016-05-09 9:37 ` Vineet Gupta
2016-05-09 9:37 ` Vineet Gupta
2016-05-09 13:54 ` Vince Weaver
2016-05-09 13:54 ` Vince Weaver
2016-05-09 17:23 ` Vineet Gupta
2016-05-09 17:23 ` Vineet Gupta
2016-05-11 3:33 ` Vince Weaver
2016-05-11 3:33 ` Vince Weaver
2016-05-11 19:36 ` Peter Zijlstra
2016-05-11 19:36 ` Peter Zijlstra
2016-05-11 19:36 ` Peter Zijlstra
2016-05-12 6:28 ` Vineet Gupta
2016-05-12 6:28 ` Vineet Gupta
2016-05-12 6:28 ` Vineet Gupta
2016-05-12 6:42 ` Peter Zijlstra [this message]
2016-05-12 6:42 ` Peter Zijlstra
2016-05-12 6:42 ` Peter Zijlstra
2016-05-12 6:54 ` Vineet Gupta
2016-05-12 6:54 ` Vineet Gupta
2016-05-12 6:54 ` Vineet Gupta
2016-05-12 7:25 ` Peter Zijlstra
2016-05-12 7:25 ` Peter Zijlstra
2016-05-12 7:25 ` Peter Zijlstra
2016-05-12 23:04 ` Vince Weaver
2016-05-12 23:04 ` Vince Weaver
2016-05-13 8:36 ` Vineet Gupta
2016-05-13 8:36 ` Vineet Gupta
2016-05-13 8:36 ` Vineet Gupta
2016-05-30 11:31 ` [PATCH-REBASED 0/2] report perf sampling failing due to PMU lacking overflow intr support Vineet Gupta
2016-05-30 11:31 ` Vineet Gupta
2016-05-30 11:31 ` Vineet Gupta
2016-05-30 11:31 ` [PATCH-REBASED 1/2] tools/perf: Handle EOPNOTSUPP for sampling events Vineet Gupta
2016-05-30 11:31 ` Vineet Gupta
2016-05-30 11:31 ` Vineet Gupta
2016-05-30 11:31 ` [PATCH-REBASED 2/2] perf/core: change errno for sampling event not supported in hardware Vineet Gupta
2016-05-30 11:31 ` Vineet Gupta
2016-05-30 11:31 ` Vineet Gupta
2016-06-03 10:51 ` [tip:perf/core] perf/abi: Change the " tip-bot for Vineet Gupta
2016-06-03 10:51 ` tip-bot for Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512064201.GL3192@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Vineet.Gupta1@synopsys.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mingo@kernel.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.