From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407AbcELHak (ORCPT ); Thu, 12 May 2016 03:30:40 -0400 Received: from verein.lst.de ([213.95.11.211]:48265 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbcELHaj (ORCPT ); Thu, 12 May 2016 03:30:39 -0400 Date: Thu, 12 May 2016 09:30:37 +0200 From: Christoph Hellwig To: "Dmitry V. Levin" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: use compat version for preadv2 and pwritev2 Message-ID: <20160512073037.GA3852@lst.de> References: <20160511084817.GA29823@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160511084817.GA29823@altlinux.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 11:48:17AM +0300, Dmitry V. Levin wrote: > Similar to preadv and pwritev, preadv2 and pwritev2 need compat entries > in the 32-bit syscall table. > > This bug was found by strace test suite. Looks fine, thanks. Btw, can we have a sensible format for the syscalls list that explicitly requires adding _something_ for the compat entry so that errors by ommision like this can't happen? Reviewed-by: Christoph Hellwig