diff for duplicates of <20160512083047.GY3733@lukather> diff --git a/a/1.txt b/N1/1.txt index 9dc6905..252b5e1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,11 +25,11 @@ On Thu, May 12, 2016 at 08:59:43AM +0200, Maxime Ripard wrote: > > > > > @@ -107,7 +107,7 @@ static int > > > > > sun4i_a10_display_reset_xlate(struct > > > > > reset_controller_dev *rcdev, -> > > > > static void __init sun4i_a10_display_init(struct device_node +> > > > > ?static void __init sun4i_a10_display_init(struct device_node > > > > > *node, -> > > > > const struct +> > > > > ? ??const struct > > > > > sun4i_a10_display_clk_data *data) -> > > > > { +> > > > > ?{ > > > > > - const char *parents[data->parents]; > > > > > + const char *parents[4]; > > > > This change breaks at least de_[bf]e clocks which have 3 clock @@ -38,13 +38,13 @@ On Thu, May 12, 2016 at 08:59:43AM +0200, Maxime Ripard wrote: > > > I just used the largest data->parents number, which was 4. How > > > does that break anything? > > -> > If you look at the sun4i_a10_display_init, it contains this block: +> > If you look at the?sun4i_a10_display_init, it contains this block: > > -> > ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents)); -> > if (ret != ARRAY_SIZE(parents)) { -> > pr_err("%s: Could not retrieve the parents\n", clk_name); -> > goto unmap; -> > } +> > ? ? ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents)); +> > ????if (ret != ARRAY_SIZE(parents)) { +> > ????????pr_err("%s: Could not retrieve the parents\n", clk_name); +> > ????????goto unmap; +> > ????} > > > > of_clk_parent_fill returns 3 for de_be/de_fe nodes, and > > ARRAY_SIZE(parents) is 4. @@ -79,3 +79,10 @@ Maxime Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com +-------------- next part -------------- +A non-text attachment was scrubbed... +Name: signature.asc +Type: application/pgp-signature +Size: 819 bytes +Desc: not available +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160512/bea383f2/attachment.sig> diff --git a/a/2.bin b/a/2.bin deleted file mode 100644 index 25a8a13..0000000 --- a/a/2.bin +++ /dev/null @@ -1,17 +0,0 @@ ------BEGIN PGP SIGNATURE----- -Version: GnuPG v1 - -iQIcBAEBAgAGBQJXND83AAoJEBx+YmzsjxAgf1IQAJ1UEiWAWz/bJ6uEhMjY9ZWz -8fBlBkRyjllOW+WMgMUSv9r8VJhUjQ/0g9g2lyS0k0U0l24s9hTvcGdfrDXqDVMJ -E6aSdiQEGnSZkSseioTLd1MMtgACb29ilb71LQDjna7bYydsUZRVa7TOgN/Rs28p -t+w/GJTFxJFpxWLoD0z/jKy3eb0a/ec1X6nar/cWYqC62o27gGCzolgSis0ZcT1v -9/9SRlKaenE4a+xTt4fVnCnfIe+86itvTTyv0BN+TOqVtRTQKoPQQ6IgVzp0tAH8 -XLsnHtOss/jKM6YU2hBOD/yaOILlukTgJGb7IfEr7b1AbpAgNUp2cUQO6/b64CJE -zbWHMNd9gMWquED1WUwM3NF1wyLQbD+Pc33dRr+MA9yGR5U+RU6c7KgbT3iEuyFq -wdCOhT3T4Fhl/LoS5ryc30/X2qpMIdiCiMig6D/UihTiftCWiM2bydFBZfpXx5kE -9FfF4MMcgPi1IfdDBESw/lLJiwVSjRktNobUCQcUkCh8KPQgctHQDWR9roJ9urNC -jJ/ULcTnqWl9qY/hDylzxY73C+KVV0iHWh6WerYtMgcRKcNixFa4idFvta419QIZ -1jfMqPvB6piVIAjQW/krbu5HGNVmL38M9fmXNbD4qFajRzrNP1kc4P1x+F90xDsH -ot7VHWLsQ26r5+aZV1Pl -=N8ET ------END PGP SIGNATURE----- diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index 5e5352c..0000000 --- a/a/2.hdr +++ /dev/null @@ -1 +0,0 @@ -Content-Type: application/pgp-signature; name="signature.asc" diff --git a/a/content_digest b/N1/content_digest index 6bf3701..d4dde16 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,28 +8,11 @@ "ref\020160511221541.GG3492@codeaurora.org\0" "ref\01463024360.16747.4.camel@plaes.org\0" "ref\020160512065943.GX3733@lukather\0" - "From\0Maxime Ripard <maxime.ripard@free-electrons.com>\0" - "Subject\0Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver\0" + "From\0maxime.ripard@free-electrons.com (Maxime Ripard)\0" + "Subject\0[linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver\0" "Date\0Thu, 12 May 2016 10:30:47 +0200\0" - "To\0Priit Laes <plaes@plaes.org>\0" - "Cc\0Stephen Boyd <sboyd@codeaurora.org>" - Mike Turquette <mturquette@baylibre.com> - David Airlie <airlied@linux.ie> - Chen-Yu Tsai <wens@csie.org> - Rob Herring <robh+dt@kernel.org> - Daniel Vetter <daniel@ffwll.ch> - Hans de Goede <hdegoede@redhat.com> - devicetree@vger.kernel.org - linux-clk@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-kernel@vger.kernel.org - linux-sunxi@googlegroups.com - dri-devel@lists.freedesktop.org - Boris Brezillon <boris.brezillon@free-electrons.com> - Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - Alexander Kaplan <alex@nextthing.co> - " Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" - "\01:1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" "On Thu, May 12, 2016 at 08:59:43AM +0200, Maxime Ripard wrote:\n" "> On Thu, May 12, 2016 at 06:39:20AM +0300, Priit Laes wrote:\n" @@ -58,11 +41,11 @@ "> > > > > @@ -107,7 +107,7 @@ static int\n" "> > > > > sun4i_a10_display_reset_xlate(struct\n" "> > > > > reset_controller_dev *rcdev,\n" - "> > > > > \302\240static void __init sun4i_a10_display_init(struct device_node\n" + "> > > > > ?static void __init sun4i_a10_display_init(struct device_node\n" "> > > > > *node,\n" - "> > > > > \302\240\t\t\t\t\t\302\240\302\240const struct\n" + "> > > > > ?\t\t\t\t\t??const struct\n" "> > > > > sun4i_a10_display_clk_data *data)\n" - "> > > > > \302\240{\n" + "> > > > > ?{\n" "> > > > > -\tconst char *parents[data->parents];\n" "> > > > > +\tconst char *parents[4];\n" "> > > > This change breaks at least de_[bf]e clocks which have 3 clock\n" @@ -71,13 +54,13 @@ "> > > I just used the largest data->parents number, which was 4. How\n" "> > > does that break anything?\n" "> > \n" - "> > If you look at the\302\240sun4i_a10_display_init, it contains this block:\n" + "> > If you look at the?sun4i_a10_display_init, it contains this block:\n" "> > \n" - "> > \302\240 \302\240 ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents));\n" - "> > \302\240\302\240\302\240\302\240if (ret != ARRAY_SIZE(parents)) {\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pr_err(\"%s: Could not retrieve the parents\\n\", clk_name);\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240goto unmap;\n" - "> > \302\240\302\240\302\240\302\240}\n" + "> > ? ? ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents));\n" + "> > ????if (ret != ARRAY_SIZE(parents)) {\n" + "> > ????????pr_err(\"%s: Could not retrieve the parents\\n\", clk_name);\n" + "> > ????????goto unmap;\n" + "> > ????}\n" "> > \n" "> > of_clk_parent_fill returns 3 for de_be/de_fe nodes, and\n" "> > ARRAY_SIZE(parents) is 4.\n" @@ -111,26 +94,13 @@ "-- \n" "Maxime Ripard, Free Electrons\n" "Embedded Linux, Kernel and Android engineering\n" - http://free-electrons.com - "\01:2\0" - "fn\0signature.asc\0" - "b\0" - "-----BEGIN PGP SIGNATURE-----\n" - "Version: GnuPG v1\n" - "\n" - "iQIcBAEBAgAGBQJXND83AAoJEBx+YmzsjxAgf1IQAJ1UEiWAWz/bJ6uEhMjY9ZWz\n" - "8fBlBkRyjllOW+WMgMUSv9r8VJhUjQ/0g9g2lyS0k0U0l24s9hTvcGdfrDXqDVMJ\n" - "E6aSdiQEGnSZkSseioTLd1MMtgACb29ilb71LQDjna7bYydsUZRVa7TOgN/Rs28p\n" - "t+w/GJTFxJFpxWLoD0z/jKy3eb0a/ec1X6nar/cWYqC62o27gGCzolgSis0ZcT1v\n" - "9/9SRlKaenE4a+xTt4fVnCnfIe+86itvTTyv0BN+TOqVtRTQKoPQQ6IgVzp0tAH8\n" - "XLsnHtOss/jKM6YU2hBOD/yaOILlukTgJGb7IfEr7b1AbpAgNUp2cUQO6/b64CJE\n" - "zbWHMNd9gMWquED1WUwM3NF1wyLQbD+Pc33dRr+MA9yGR5U+RU6c7KgbT3iEuyFq\n" - "wdCOhT3T4Fhl/LoS5ryc30/X2qpMIdiCiMig6D/UihTiftCWiM2bydFBZfpXx5kE\n" - "9FfF4MMcgPi1IfdDBESw/lLJiwVSjRktNobUCQcUkCh8KPQgctHQDWR9roJ9urNC\n" - "jJ/ULcTnqWl9qY/hDylzxY73C+KVV0iHWh6WerYtMgcRKcNixFa4idFvta419QIZ\n" - "1jfMqPvB6piVIAjQW/krbu5HGNVmL38M9fmXNbD4qFajRzrNP1kc4P1x+F90xDsH\n" - "ot7VHWLsQ26r5+aZV1Pl\n" - "=N8ET\n" - "-----END PGP SIGNATURE-----\n" + "http://free-electrons.com\n" + "-------------- next part --------------\n" + "A non-text attachment was scrubbed...\n" + "Name: signature.asc\n" + "Type: application/pgp-signature\n" + "Size: 819 bytes\n" + "Desc: not available\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160512/bea383f2/attachment.sig> -365781e7c0b8a4c9b2d8df997ad01d56ea6715ec9b2ed7ade7994da12fe640d7 +ee595f0ad0dfafe1a1524c75e74cde63af40d3ce9d8e8915a732df5b3c745010
diff --git a/a/1.txt b/N2/1.txt index 9dc6905..ea829e8 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -79,3 +79,8 @@ Maxime Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com + +-- +You received this message because you are subscribed to the Google Groups "linux-sunxi" group. +To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org +For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N2/content_digest index 6bf3701..978e068 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -8,27 +8,27 @@ "ref\020160511221541.GG3492@codeaurora.org\0" "ref\01463024360.16747.4.camel@plaes.org\0" "ref\020160512065943.GX3733@lukather\0" - "From\0Maxime Ripard <maxime.ripard@free-electrons.com>\0" - "Subject\0Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver\0" + "From\0Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" + "Subject\0Re: Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver\0" "Date\0Thu, 12 May 2016 10:30:47 +0200\0" - "To\0Priit Laes <plaes@plaes.org>\0" - "Cc\0Stephen Boyd <sboyd@codeaurora.org>" - Mike Turquette <mturquette@baylibre.com> - David Airlie <airlied@linux.ie> - Chen-Yu Tsai <wens@csie.org> - Rob Herring <robh+dt@kernel.org> - Daniel Vetter <daniel@ffwll.ch> - Hans de Goede <hdegoede@redhat.com> - devicetree@vger.kernel.org - linux-clk@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-kernel@vger.kernel.org - linux-sunxi@googlegroups.com - dri-devel@lists.freedesktop.org - Boris Brezillon <boris.brezillon@free-electrons.com> - Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - Alexander Kaplan <alex@nextthing.co> - " Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" + "To\0Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>\0" + "Cc\0Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>" + Mike Turquette <mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> + David Airlie <airlied-cv59FeDIM0c@public.gmane.org> + Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> + Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org> + Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org + dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org + Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> + Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> + Alexander Kaplan <alex-MflLfwwFzuz+yO7R74ARew@public.gmane.org> + " Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>\0" "\01:1\0" "b\0" "On Thu, May 12, 2016 at 08:59:43AM +0200, Maxime Ripard wrote:\n" @@ -111,7 +111,12 @@ "-- \n" "Maxime Ripard, Free Electrons\n" "Embedded Linux, Kernel and Android engineering\n" - http://free-electrons.com + "http://free-electrons.com\n" + "\n" + "-- \n" + "You received this message because you are subscribed to the Google Groups \"linux-sunxi\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org\n" + For more options, visit https://groups.google.com/d/optout. "\01:2\0" "fn\0signature.asc\0" "b\0" @@ -133,4 +138,4 @@ "=N8ET\n" "-----END PGP SIGNATURE-----\n" -365781e7c0b8a4c9b2d8df997ad01d56ea6715ec9b2ed7ade7994da12fe640d7 +109083ad6461697b9a6b51160a2835ab2f7380f9a2714ecbd0cf5a2154fac616
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.