From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH v4 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k Date: Thu, 12 May 2016 10:51:42 +0200 Message-ID: <20160512085142.GX29844@pali> References: <1459833007-11618-1-git-send-email-jgross@suse.com> <1459833007-11618-7-git-send-email-jgross@suse.com> <20160405145414.GB27359@roeck-us.net> <201604052131.52765@pali> <20160421105724.GK29406@pali> <5718D1D4.3040309@suse.com> <20160421132735.GR29406@pali> <5730A08D.60100@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5730A08D.60100@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Juergen Gross Cc: x86@kernel.org, jeremy@goop.org, jdelvare@suse.com, peterz@infradead.org, akataria@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, chrisw@sous-sol.org, mingo@redhat.com, david.vrabel@citrix.com, Douglas_Warzecha@dell.com, hpa@zytor.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, tglx@linutronix.de, Guenter Roeck List-Id: virtualization@lists.linuxfoundation.org T24gTW9uZGF5IDA5IE1heSAyMDE2IDE2OjM3OjAxIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6Cj4gT24g MjEvMDQvMTYgMTU6MjcsIFBhbGkgUm9ow6FyIHdyb3RlOgo+ID4gT24gVGh1cnNkYXkgMjEgQXBy aWwgMjAxNiAxNToxMjo1MiBKdWVyZ2VuIEdyb3NzIHdyb3RlOgo+ID4+IE9uIDIxLzA0LzE2IDEy OjU3LCBQYWxpIFJvaMOhciB3cm90ZToKPiA+Pj4gT24gVHVlc2RheSAwNSBBcHJpbCAyMDE2IDIx OjMxOjUyIFBhbGkgUm9ow6FyIHdyb3RlOgo+ID4+Pj4gT24gVHVlc2RheSAwNSBBcHJpbCAyMDE2 IDE2OjU0OjE0IEd1ZW50ZXIgUm9lY2sgd3JvdGU6Cj4gPj4+Pj4gT24gVHVlLCBBcHIgMDUsIDIw MTYgYXQgMDc6MTA6MDdBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiA+Pj4+Pj4gVXNl IHRoZSBzbXBfY2FsbF9vbl9jcHUoKSBmdW5jdGlvbiB0byBjYWxsIHN5c3RlbSBtYW5hZ2VtZW50 Cj4gPj4+Pj4+IG1vZGUgb24gY3B1IDAuCj4gPj4+Pj4+IE1ha2UgY2FsbCBzZWN1cmUgYnkgYWRk aW5nIGdldF9vbmxpbmVfY3B1cygpIHRvIGF2b2lkIGUuZy4gc3VzcGVuZAo+ID4+Pj4+PiByZXN1 bWUgY3ljbGVzIGluIGJldHdlZW4uCj4gPj4+Pj4+Cj4gPj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KPiA+Pj4+Pj4gLS0tCj4gPj4+Pj4+IFY0OiBh ZGQgY2FsbCB0byBnZXRfb25saW5lX2NwdXMoKQo+ID4+Pj4+Cj4gPj4+Pj4gUGFsaSwgYW55IGNo YW5jZSB0byB0ZXN0IHRoaXMgPwo+ID4+Pj4KPiA+Pj4+IEkgY2FuIHRlc3QgaXQsIGJ1dCBqdXN0 IG9uIG1hY2hpbmUgd2hlcmUgKHByb2JhYmx5KSBzbW0gY2FsbHMgY2FuIGJlIAo+ID4+Pj4gc2Vu ZCBmcm9tIGFueSBjcHUuLi4gTmVlZCBzb21lIHRpbWUgZm9yIHRlc3RpbmcgYW5kIEkgYmVsaWV2 ZSBJIGNhbiBkbyAKPiA+Pj4+IHRoYXQgYXQgdGhlIGVuZCBvZiB0aGUgd2Vlay4KPiA+Pj4KPiA+ Pj4gU29ycnkgSSBoYWQgYWJzb2x1dGVseSBubyBtb3JlIGZyZWUgdGltZSBsYXN0IHdlZWtlbmQg Oi0oIEFuZCBzYW1lCj4gPj4+IHByZWRpY3Rpb24gaXMgZm9yIHRoaXMgd2Vla2VuZCBhbmQgYWxz byBuZXh0IG9uZS4uLgo+ID4+Cj4gPj4gUGFsaSwgSSd2ZSBnb3QgYSBEZWxsIGxhcHRvcCAoTGF0 aXR1ZGUgRTY0NDApIGhlcmUuIFdvdWxkIHRoaXMgZGV2aWNlIGJlCj4gPj4gb2theSBmb3IgYSB0 ZXN0Pwo+ID4gCj4gPiBIaSEKPiA+IAo+ID4gUHJvcGVyIHJlZ3Jlc3Npb24gdGVzdCBzaG91bGQg Y2hlY2sgaWYgdGhpcyBwYXRjaCBkb2VzIG5vdCBicmVhayBhbnkKPiA+IGZ1bmN0aW9uIG9yIGRy aXZlcnMgZGVwZW5kZW50IG9uIGRjZGJhcy5rby4gQW5kIHNob3VsZCBiZSBkb25lIG9uIGJvdGgK PiA+IG5vdGVib29rIGRldmljZXM6IHdoaWNoIG5lZWRzIHRvIGlzc3VlIHRoYXQgc21tIGNhbGwg b24gY3B1IDAgYW5kIGFsc28KPiA+IG9uIHdoaWNoIGl0IGlzIG5vdCBuZWVkZWQuCj4gCj4gSG1t LCBjb3VsZG4ndCBnZXQgb25lIHdoaWNoIG5lZWRzIHNtbSB0byBiZSBjYWxsZWQgb24gY3B1IDAu Cj4gT1RPSCBJJ3ZlIGRvbmUgdmFyaW91cyB0ZXN0cyBhbmQgYWRkZWQgYSBwcmludGsoKSBpbiBy YWlzZV9zbW0oKQo+IGFuZCBpOGtfc21tX2Z1bmMoKSBpc3N1aW5nIHRoZSBjcHUgbnVtYmVyIGl0 IHdhcyBjYWxsZWQgb24uCgpVbmRlcnN0b29kLCB0aG9zZSBtYWNoaW5lcyBhcmUgb2xkIGFuZCBw cm9iYWJseSByYXJlIG5vdy4KCj4gPiBTb21lIG5vdGVib29rcyB3aGljaCBuZWVkcyBzbW0gY2Fs bCB0byBpc3N1ZWQgZnJvbSBjcHUgMCBjYW4gYmUgZm91bmQgaW4KPiA+IGdpdCBjb21taXQgbWVz c2FnZXMgb2YgaThrLCBkZWxsLWxhcHRvcCBvciBkY2RiYXMga2VybmVsIGRyaXZlcnMuCj4gPiAK PiA+PiBXaGF0IHdvdWxkIHlvdSBkbyBmb3IgdGVzdGluZz8gSW4gY2FzZSB5b3UgY2FuIGdpdmUg bWUKPiA+PiBzb21lIGhpbnRzIGhvdyB0byBkbyBhIHNlbnNpYmxlIHRlc3QgSSdkIGRvIGl0Lgo+ ID4gCj4gPiBUZXN0IGUuZy4gZGVsbC1sYXB0b3Aua28gZHJpdmVyLiBJdCBwcm92aWRlcyAvc3lz IGludGVyZmFjZSBmb3IgY2hhbmdpbmcKPiA+IGtleWJvYXJkIGJhY2tsaWdodCBvciBjaGFuZ2lu ZyByZmtpbGwgc3dpdGNoZXMgKGJsdWV0b290aCB3aWZpKS4KPiAKPiBEb25lLgo+IAo+ID4gQWxz byB0ZXN0IHRvb2xzIGZyb20gbGlic21iaW9zICh1c2Vyc3BhY2UpIHBhY2thZ2UuCj4gCj4gRG9u ZS4KPiAKPiA+IFRoZXJlIG11c3QgYmUgbm8gZGlmZmVyZW5jZSBpbiBvdXRwdXQvZnVuY3Rpb25h bGl0eSB3aXRoIG9yIHdpdGhvdXQgeW91cgo+ID4gcGF0Y2hlcy4KPiAKPiBWZXJpZmllZC4KPiAK PiA+PiBJJ3ZlIHZlcmlmaWVkIGJ5IGFkZGluZyBhIHByaW50aygpIHRvIHNtcF9jYWxsX29uX2Nw dSgpIHRoYXQgYXQgbGVhc3QKPiA+PiBvbmUgb2YgdGhlIG1vZGlmaWVkIGRyaXZlcnMgaGFzIGJl ZW4gdXNlZCBkdXJpbmcgc3lzdGVtIGJvb3QuCj4gPiAKPiA+IEFsc28geW91IGNhbiBwYXRjaCBp OGsvZGNkYmFzIHNtbSBmdW5jdGlvbiB0byBwcmludCBjcHUgbnVtYmVyIG9uIHdoaWNoCj4gPiBp cyBjb2RlIHJ1bm5pbmcgKHRvIHZlcmlmeSB0aGF0IGl0IHdhcyByZWFsbHkgY2FsbGVkIG9uIGNw dSAwIGFzCj4gPiBuZWVkZWQpLgo+IAo+IERvbmUuCj4gCj4gSSB0ZXN0ZWQgc3VzcGVuZC9yZXN1 bWUsIHRvbywgYXMgYWRkaW5nIGdldF9vbmxpbmVfY3B1cygpIG1pZ2h0IGhhdmUKPiBjaGFuZ2Vk IGJlaGF2aW9yLiBXb3JrZWQgbGlrZSBhIGNoYXJtLiA6LSkKCk9rLCBJIHRoaW5rIHRoaXMgc2hv dWxkIGJlIGVub3VnaC4gWW91IGNhbiBhZGQgbXkgQWNrZWQtYnkuCgotLSAKUGFsaSBSb2jDoXIK cGFsaS5yb2hhckBnbWFpbC5jb20KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxp c3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932334AbcELIwa (ORCPT ); Thu, 12 May 2016 04:52:30 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36840 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752891AbcELIvp (ORCPT ); Thu, 12 May 2016 04:51:45 -0400 Date: Thu, 12 May 2016 10:51:42 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Juergen Gross Cc: Guenter Roeck , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, mingo@redhat.com, peterz@infradead.org, Douglas_Warzecha@dell.com, jdelvare@suse.com, tglx@linutronix.de, hpa@zytor.com, jeremy@goop.org, chrisw@sous-sol.org, akataria@vmware.com, rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH v4 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k Message-ID: <20160512085142.GX29844@pali> References: <1459833007-11618-1-git-send-email-jgross@suse.com> <1459833007-11618-7-git-send-email-jgross@suse.com> <20160405145414.GB27359@roeck-us.net> <201604052131.52765@pali> <20160421105724.GK29406@pali> <5718D1D4.3040309@suse.com> <20160421132735.GR29406@pali> <5730A08D.60100@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5730A08D.60100@suse.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 09 May 2016 16:37:01 Juergen Gross wrote: > On 21/04/16 15:27, Pali Rohár wrote: > > On Thursday 21 April 2016 15:12:52 Juergen Gross wrote: > >> On 21/04/16 12:57, Pali Rohár wrote: > >>> On Tuesday 05 April 2016 21:31:52 Pali Rohár wrote: > >>>> On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > >>>>> On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > >>>>>> Use the smp_call_on_cpu() function to call system management > >>>>>> mode on cpu 0. > >>>>>> Make call secure by adding get_online_cpus() to avoid e.g. suspend > >>>>>> resume cycles in between. > >>>>>> > >>>>>> Signed-off-by: Juergen Gross > >>>>>> --- > >>>>>> V4: add call to get_online_cpus() > >>>>> > >>>>> Pali, any chance to test this ? > >>>> > >>>> I can test it, but just on machine where (probably) smm calls can be > >>>> send from any cpu... Need some time for testing and I believe I can do > >>>> that at the end of the week. > >>> > >>> Sorry I had absolutely no more free time last weekend :-( And same > >>> prediction is for this weekend and also next one... > >> > >> Pali, I've got a Dell laptop (Latitude E6440) here. Would this device be > >> okay for a test? > > > > Hi! > > > > Proper regression test should check if this patch does not break any > > function or drivers dependent on dcdbas.ko. And should be done on both > > notebook devices: which needs to issue that smm call on cpu 0 and also > > on which it is not needed. > > Hmm, couldn't get one which needs smm to be called on cpu 0. > OTOH I've done various tests and added a printk() in raise_smm() > and i8k_smm_func() issuing the cpu number it was called on. Understood, those machines are old and probably rare now. > > Some notebooks which needs smm call to issued from cpu 0 can be found in > > git commit messages of i8k, dell-laptop or dcdbas kernel drivers. > > > >> What would you do for testing? In case you can give me > >> some hints how to do a sensible test I'd do it. > > > > Test e.g. dell-laptop.ko driver. It provides /sys interface for changing > > keyboard backlight or changing rfkill switches (bluetooth wifi). > > Done. > > > Also test tools from libsmbios (userspace) package. > > Done. > > > There must be no difference in output/functionality with or without your > > patches. > > Verified. > > >> I've verified by adding a printk() to smp_call_on_cpu() that at least > >> one of the modified drivers has been used during system boot. > > > > Also you can patch i8k/dcdbas smm function to print cpu number on which > > is code running (to verify that it was really called on cpu 0 as > > needed). > > Done. > > I tested suspend/resume, too, as adding get_online_cpus() might have > changed behavior. Worked like a charm. :-) Ok, I think this should be enough. You can add my Acked-by. -- Pali Rohár pali.rohar@gmail.com